From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Liu Shengzhou-B36685 <B36685@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Pavan Kondeti <pkondeti@codeaurora.org>
Subject: RE: [PATCH] powerpc/usb: fix issue of CPU halt when missing USB PHY clock
Date: Wed, 15 Feb 2012 13:31:04 +1100 [thread overview]
Message-ID: <1329273064.3772.18.camel@pasglop> (raw)
In-Reply-To: <3F453DDFF675A64A89321A1F352810216EDA8B@039-SN1MPN1-005.039d.mgd.msft.net>
> > > + if (!(in_be32(non_ehci + FSL_SOC_USB_CTRL) & CTRL_PHY_CLK_VALID))
> > {
> > > + printk(KERN_WARNING "fsl-ehci: USB PHY clock invalid\n");
> > > + return -1;
> >
> > Please return a proper error code. -ENODEV ?
>
> [Shengzhou] Ok, updated in v2, thanks.
> >
Note that I just got a p5020ds from FSL, and with it's default
configuration, when I build & boot current upstream with FSL USB
support (64-bit kernel) it hangs when initializing USB.
With or without this patch.
It complains about invalid dr-mode (there's two USB nodes in the .dts
coming from uboot, an "mph" and "dr", the former has no dr-mode property
in the device-tree.
Is the current kernel incompatible with old device-tree's ? (that would
be a shame...)
Cheers,
Ben.
next prev parent reply other threads:[~2012-02-15 2:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 9:20 [PATCH] powerpc/usb: fix issue of CPU halt when missing USB PHY clock Shengzhou Liu
2012-02-01 10:11 ` Pavan Kondeti
2012-02-02 3:31 ` Liu Shengzhou-B36685
2012-02-15 2:31 ` Benjamin Herrenschmidt [this message]
2012-02-16 10:16 ` Liu Shengzhou-B36685
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329273064.3772.18.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B36685@freescale.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pkondeti@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).