From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-arch@vger.kernel.org, linux-pci@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags
Date: Thu, 23 Feb 2012 08:41:39 +1100 [thread overview]
Message-ID: <1329946899.20389.9.camel@pasglop> (raw)
In-Reply-To: <20120222181948.27513.96215.stgit@bhelgaas.mtv.corp.google.com>
On Wed, 2012-02-22 at 11:19 -0700, Bjorn Helgaas wrote:
> int maple_pci_get_legacy_ide_irq(struct pci_dev *pdev, int channel)
> diff --git a/arch/powerpc/platforms/pasemi/pci.c
> b/arch/powerpc/platforms/pasemi/pci.c
> index b6a0ec4..b27d886 100644
> --- a/arch/powerpc/platforms/pasemi/pci.c
> +++ b/arch/powerpc/platforms/pasemi/pci.c
> @@ -231,7 +231,7 @@ void __init pas_pci_init(void)
> pci_devs_phb_init();
>
> /* Use the common resource allocation mechanism */
> - pci_probe_only = 1;
> + pci_add_flags(PCI_PROBE_ONLY);
> }
Olof, do you remember why you used to set that on pasemi ?
I would have expected it to be clear, so the kernel can re-assign things
if needed. We really only want it set for pseries because of the
hypervisor being a PITA :-)
Cheers,
Ben.
next prev parent reply other threads:[~2012-02-22 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120222181556.27513.9413.stgit@bhelgaas.mtv.corp.google.com>
2012-02-22 18:19 ` [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags Bjorn Helgaas
2012-02-22 21:41 ` Benjamin Herrenschmidt [this message]
2012-02-23 18:49 ` Bjorn Helgaas
2012-03-05 3:54 ` Olof Johansson
2012-03-05 3:59 ` Olof Johansson
2012-02-22 21:41 ` Benjamin Herrenschmidt
2012-02-22 22:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329946899.20389.9.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).