* [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds
@ 2012-02-21 23:10 Paul Gortmaker
2012-02-27 1:26 ` Paul Gortmaker
0 siblings, 1 reply; 4+ messages in thread
From: Paul Gortmaker @ 2012-02-21 23:10 UTC (permalink / raw)
To: Gang.Liu; +Cc: Paul Gortmaker, linuxppc-dev
The following are seen while using the corenet64_smp_defconfig:
arch/powerpc/sysdev/fsl_rmu.c:315: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:330: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:332: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:339: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:340: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:341: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:659: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:659: error: format '%8.8x' expects type 'unsigned int', but argument 5 has type 'size_t'
arch/powerpc/sysdev/fsl_rmu.c:985: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:997: error: cast to pointer from integer of different size
A quick inspection of the code leaves one with the impression
that it was not explicitly written with 64 bit support in mind,
so just block that as a possible config selection for now.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[This is seen in linux-next -- not sure if this is the right way to go
but at least it will give the issue some visibility to the right ppl.]
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 75f061e..5ad8013 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -773,7 +773,7 @@ config RAPIDIO
config FSL_RIO
bool "Freescale Embedded SRIO Controller support"
- depends on RAPIDIO && HAS_RAPIDIO
+ depends on RAPIDIO && HAS_RAPIDIO && (BROKEN || !PPC64)
default "n"
---help---
Include support for RapidIO controller on Freescale embedded
--
1.7.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds
2012-02-21 23:10 [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds Paul Gortmaker
@ 2012-02-27 1:26 ` Paul Gortmaker
2012-02-27 1:49 ` Benjamin Herrenschmidt
2012-02-27 6:48 ` Liu Gang
0 siblings, 2 replies; 4+ messages in thread
From: Paul Gortmaker @ 2012-02-27 1:26 UTC (permalink / raw)
To: benh; +Cc: Gang.Liu, linux-next, linuxppc-dev
Hi Ben,
Given a week has passed with the absence of any feedback
with respect to SRIO on 64 bit, are you OK with applying the
below patch[1] pretty much as-is?
Thanks,
Paul.
[1] http://patchwork.ozlabs.org/patch/142383/
---
On Tue, Feb 21, 2012 at 6:10 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> The following are seen while using the corenet64_smp_defconfig:
>
> arch/powerpc/sysdev/fsl_rmu.c:315: error: cast from pointer to integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:330: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:332: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:339: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:340: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:341: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:659: error: cast from pointer to integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:659: error: format '%8.8x' expects type 'un=
signed int', but argument 5 has type 'size_t'
> arch/powerpc/sysdev/fsl_rmu.c:985: error: cast from pointer to integer of=
different size
> arch/powerpc/sysdev/fsl_rmu.c:997: error: cast to pointer from integer of=
different size
>
> A quick inspection of the code leaves one with the impression
> that it was not explicitly written with 64 bit support in mind,
> so just block that as a possible config selection for now.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> ---
>
> [This is seen in linux-next -- not sure if this is the right way to go
> =A0but at least it will give the issue some visibility to the right ppl.]
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 75f061e..5ad8013 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -773,7 +773,7 @@ config RAPIDIO
>
> =A0config FSL_RIO
> =A0 =A0 =A0 =A0bool "Freescale Embedded SRIO Controller support"
> - =A0 =A0 =A0 depends on RAPIDIO && HAS_RAPIDIO
> + =A0 =A0 =A0 depends on RAPIDIO && HAS_RAPIDIO && (BROKEN || !PPC64)
> =A0 =A0 =A0 =A0default "n"
> =A0 =A0 =A0 =A0---help---
> =A0 =A0 =A0 =A0 =A0Include support for RapidIO controller on Freescale em=
bedded
> --
> 1.7.9.1
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds
2012-02-27 1:26 ` Paul Gortmaker
@ 2012-02-27 1:49 ` Benjamin Herrenschmidt
2012-02-27 6:48 ` Liu Gang
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2012-02-27 1:49 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Gang.Liu, linux-next, linuxppc-dev
On Sun, 2012-02-26 at 20:26 -0500, Paul Gortmaker wrote:
> Hi Ben,
>
> Given a week has passed with the absence of any feedback
> with respect to SRIO on 64 bit, are you OK with applying the
> below patch[1] pretty much as-is?
It can't hurt, I'll put it in. That's normally Kumar's side of things
but then with him leaving FSL things are a bit in flux right now.
Cheers,
Ben.
> Thanks,
> Paul.
>
> [1] http://patchwork.ozlabs.org/patch/142383/
>
> ---
>
> On Tue, Feb 21, 2012 at 6:10 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > The following are seen while using the corenet64_smp_defconfig:
> >
> > arch/powerpc/sysdev/fsl_rmu.c:315: error: cast from pointer to integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:330: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:332: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:339: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:340: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:341: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:659: error: cast from pointer to integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:659: error: format '%8.8x' expects type 'unsigned int', but argument 5 has type 'size_t'
> > arch/powerpc/sysdev/fsl_rmu.c:985: error: cast from pointer to integer of different size
> > arch/powerpc/sysdev/fsl_rmu.c:997: error: cast to pointer from integer of different size
> >
> > A quick inspection of the code leaves one with the impression
> > that it was not explicitly written with 64 bit support in mind,
> > so just block that as a possible config selection for now.
> >
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> >
> > ---
> >
> > [This is seen in linux-next -- not sure if this is the right way to go
> > but at least it will give the issue some visibility to the right ppl.]
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index 75f061e..5ad8013 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -773,7 +773,7 @@ config RAPIDIO
> >
> > config FSL_RIO
> > bool "Freescale Embedded SRIO Controller support"
> > - depends on RAPIDIO && HAS_RAPIDIO
> > + depends on RAPIDIO && HAS_RAPIDIO && (BROKEN || !PPC64)
> > default "n"
> > ---help---
> > Include support for RapidIO controller on Freescale embedded
> > --
> > 1.7.9.1
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds
2012-02-27 1:26 ` Paul Gortmaker
2012-02-27 1:49 ` Benjamin Herrenschmidt
@ 2012-02-27 6:48 ` Liu Gang
1 sibling, 0 replies; 4+ messages in thread
From: Liu Gang @ 2012-02-27 6:48 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Alexandre.Bounine, linux-next, linuxppc-dev
On Sun, 2012-02-26 at 20:26 -0500, Paul Gortmaker wrote:
> Hi Ben,
>
> Given a week has passed with the absence of any feedback
> with respect to SRIO on 64 bit, are you OK with applying the
> below patch[1] pretty much as-is?
Hi, Paul, Ben,
Sorry for the late reply because of my other urgent issues. I also found
these errors of 64bit building last week. I'll provide patch for this
issue as soon as possible.
Thanks.
Best Regards,
Liu Gang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-27 6:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-21 23:10 [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds Paul Gortmaker
2012-02-27 1:26 ` Paul Gortmaker
2012-02-27 1:49 ` Benjamin Herrenschmidt
2012-02-27 6:48 ` Liu Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).