From: Liu Gang <Gang.Liu@freescale.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: r58472@freescale.com, paul.gortmaker@windriver.com,
r61911@freescale.com, linux-kernel@vger.kernel.org,
Alexandre.Bounine@idt.com, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org,
Shaohui Xie <Shaohui.Xie@freescale.com>
Subject: RE: [PATCH v2] powerpc/srio: Fix the compile errors when building with 64bit
Date: Thu, 8 Mar 2012 14:31:17 +0800 [thread overview]
Message-ID: <1331188278.23420.157.camel@10.ap.freescale.net> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6E91@saturn3.aculab.com>
Hi, David,
On Wed, 2012-03-07 at 13:18 +0000, David Laight wrote:
> > pr_debug("RIO: fsl_add_outb_message(): destid %4.4x mbox %d
> buffer " \
> > - "%8.8x len %8.8x\n", rdev->destid, mbox, (int)buffer,
> len);
> > + "%8.8lx len %8.8zx\n", rdev->destid, mbox,
> > + (unsigned long)buffer, len);
>
> Should 'buffer' be printed with %p ??
Yes, printing with "%p" can get rid of the cast, although they have the
same print results.
Thanks a lot.
Liu Gang
prev parent reply other threads:[~2012-03-08 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 12:55 [PATCH v2] powerpc/srio: Fix the compile errors when building with 64bit Liu Gang
2012-03-07 13:18 ` David Laight
2012-03-08 6:31 ` Liu Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331188278.23420.157.camel@10.ap.freescale.net \
--to=gang.liu@freescale.com \
--cc=Alexandre.Bounine@idt.com \
--cc=David.Laight@ACULAB.COM \
--cc=Shaohui.Xie@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paul.gortmaker@windriver.com \
--cc=r58472@freescale.com \
--cc=r61911@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).