3.3.0-rc6-next-20120308 boot failure on POWER7 blade

3.3.0-rc6-next-20120308 boot failure on POWER7 blade

[Anton Blanchard]

Hi,

I'm seeing this on a POWER7 blade booting 3.3.0-rc6-next-20120308:


PCI host bridge to bus 0000:00
pci_bus 0000:00: root bus resource [io  0x100000-0x10ffff] (bus address [0xf0000-0xfffff])
pci_bus 0000:00: root bus resource [mem 0x3b0000000000-0x3b001fffffff] (bus address [0xe0000000-0xffffffff])
IOMMU table initialized, virtual merging enabled
PCI host bridge to bus 0001:00
pci_bus 0001:00: root bus resource [io  0x210000-0x21ffff] (bus address [0xf0000-0xfffff])
pci_bus 0001:00: root bus resource [mem 0x3b0080000000-0x3b00ffffffff] (bus address [0x80000000-0xffffffff])
PCI host bridge to bus 0002:01
pci_bus 0002:01: root bus resource [io  0x320000-0x32ffff] (bus address [0xf0000-0xfffff])
pci_bus 0002:01: root bus resource [mem 0x3b0400000000-0x3b041fefffff] (bus address [0xe0000000-0xffefffff])
PCI: Cannot allocate resource region 0 of device 0000:00:01.0, will remap
PCI: Cannot allocate resource region 2 of device 0000:00:01.0, will remap
PCI: Cannot allocate resource region 6 of device 0000:00:01.0, will remap
PCI: Cannot allocate resource region 0 of device 0001:00:01.0, will remap
PCI: Cannot allocate resource region 0 of device 0001:00:01.1, will remap
PCI: Cannot allocate resource region 0 of device 0001:00:01.2, will remap
PCI: Cannot allocate resource region 0 of device 0002:01:00.0, will remap
PCI: Cannot allocate resource region 2 of device 0002:01:00.0, will
remap

...

pci 0001:00:01.0: device not available (can't reserve [mem 0x00000000-0x00000fff])
pci 0001:00:01.0: Can't enable PCI device, BIOS handoff failed.
pci 0001:00:01.1: device not available (can't reserve [mem 0x00000000-0x00000fff])
pci 0001:00:01.1: Can't enable PCI device, BIOS handoff failed.
pci 0001:00:01.2: device not available (can't reserve [mem 0x00000000-0x000000ff])
pci 0001:00:01.2: Can't enable PCI device, BIOS handoff failed.


Then we fail to find the root device. I haven't had a chance
to chase the cause of it down yet.

Anton

Re: 3.3.0-rc6-next-20120308 boot failure on POWER7 blade

[Benjamin Herrenschmidt]

On Fri, 2012-03-09 at 14:25 +1100, Anton Blanchard wrote:
> Hi,
> 
> I'm seeing this on a POWER7 blade booting 3.3.0-rc6-next-20120308:

Looks like something that got fixed but the new patches from Bjorn
aren't in next yet. I'll fwd you the patch separately to apply on top of
what you have see if that helps (to confirm that's indeed the issue).

Cheers,
Ben.
> 
> PCI host bridge to bus 0000:00
> pci_bus 0000:00: root bus resource [io  0x100000-0x10ffff] (bus address [0xf0000-0xfffff])
> pci_bus 0000:00: root bus resource [mem 0x3b0000000000-0x3b001fffffff] (bus address [0xe0000000-0xffffffff])
> IOMMU table initialized, virtual merging enabled
> PCI host bridge to bus 0001:00
> pci_bus 0001:00: root bus resource [io  0x210000-0x21ffff] (bus address [0xf0000-0xfffff])
> pci_bus 0001:00: root bus resource [mem 0x3b0080000000-0x3b00ffffffff] (bus address [0x80000000-0xffffffff])
> PCI host bridge to bus 0002:01
> pci_bus 0002:01: root bus resource [io  0x320000-0x32ffff] (bus address [0xf0000-0xfffff])
> pci_bus 0002:01: root bus resource [mem 0x3b0400000000-0x3b041fefffff] (bus address [0xe0000000-0xffefffff])
> PCI: Cannot allocate resource region 0 of device 0000:00:01.0, will remap
> PCI: Cannot allocate resource region 2 of device 0000:00:01.0, will remap
> PCI: Cannot allocate resource region 6 of device 0000:00:01.0, will remap
> PCI: Cannot allocate resource region 0 of device 0001:00:01.0, will remap
> PCI: Cannot allocate resource region 0 of device 0001:00:01.1, will remap
> PCI: Cannot allocate resource region 0 of device 0001:00:01.2, will remap
> PCI: Cannot allocate resource region 0 of device 0002:01:00.0, will remap
> PCI: Cannot allocate resource region 2 of device 0002:01:00.0, will
> remap
> 
> ...
> 
> pci 0001:00:01.0: device not available (can't reserve [mem 0x00000000-0x00000fff])
> pci 0001:00:01.0: Can't enable PCI device, BIOS handoff failed.
> pci 0001:00:01.1: device not available (can't reserve [mem 0x00000000-0x00000fff])
> pci 0001:00:01.1: Can't enable PCI device, BIOS handoff failed.
> pci 0001:00:01.2: device not available (can't reserve [mem 0x00000000-0x000000ff])
> pci 0001:00:01.2: Can't enable PCI device, BIOS handoff failed.
> 
> 
> Then we fail to find the root device. I haven't had a chance
> to chase the cause of it down yet.
> 
> Anton

Re: 3.3.0-rc6-next-20120308 boot failure on POWER7 blade

[Anton Blanchard]

Hi Ben,

> Looks like something that got fixed but the new patches from Bjorn
> aren't in next yet. I'll fwd you the patch separately to apply on top
> of what you have see if that helps (to confirm that's indeed the
> issue).

Thanks, confirmed that it fixes it. Patch below in case anyone else is
hitting it.

Anton

--

On Sat, 2012-03-03 at 08:52 +1100, Benjamin Herrenschmidt wrote:

> Or give me a chance to dig :-) I'll have a look next week.

This is indeed what bjorn suspected on irc, this patch fixes it:

(Bjorn, please fold it in the original offending patch)

Cheers,
Ben.

diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c
index b37d0b5..5dd63f1 100644
--- a/arch/powerpc/kernel/pci_of_scan.c
+++ b/arch/powerpc/kernel/pci_of_scan.c
@@ -75,6 +75,7 @@ static void of_pci_parse_addrs(struct device_node *node, struct pci_dev *dev)
 {
 	u64 base, size;
 	unsigned int flags;
+	struct pci_bus_region region;
 	struct resource *res;
 	const u32 *addrs;
 	u32 i;
@@ -106,10 +107,12 @@ static void of_pci_parse_addrs(struct device_node *node, struct pci_dev *dev)
 			printk(KERN_ERR "PCI: bad cfg reg num 0x%x\n", i);
 			continue;
 		}
-		res->start = base;
-		res->end = base + size - 1;
+
 		res->flags = flags;
 		res->name = pci_name(dev);
+		region.start = base;
+		region.end = base + size - 1;
+		pcibios_bus_to_resource(dev, res, &region);
 	}
 }
 
@@ -209,6 +212,7 @@ void __devinit of_scan_pci_bridge(struct pci_dev *dev)
 	struct pci_bus *bus;
 	const u32 *busrange, *ranges;
 	int len, i, mode;
+	struct pci_bus_region region;
 	struct resource *res;
 	unsigned int flags;
 	u64 size;
@@ -270,9 +274,10 @@ void __devinit of_scan_pci_bridge(struct pci_dev *dev)
 			res = bus->resource[i];
 			++i;
 		}
-		res->start = of_read_number(&ranges[1], 2);
-		res->end = res->start + size - 1;
 		res->flags = flags;
+		region.start = of_read_number(&ranges[1], 2);
+		region.end = region.start + size - 1;		
+		pcibios_bus_to_resource(dev, res, &region);
 	}
 	sprintf(bus->name, "PCI Bus %04x:%02x", pci_domain_nr(bus),
 		bus->number);


--=-aDzdhtAsqTK5gqnOark/--

Re: 3.3.0-rc6-next-20120308 boot failure on POWER7 blade

[Jesse Barnes]

On Fri, 9 Mar 2012 14:46:45 +1100
Anton Blanchard <anton@samba.org> wrote:

> 
> Hi Ben,
> 
> > Looks like something that got fixed but the new patches from Bjorn
> > aren't in next yet. I'll fwd you the patch separately to apply on
> > top of what you have see if that helps (to confirm that's indeed the
> > issue).
> 
> Thanks, confirmed that it fixes it. Patch below in case anyone else is
> hitting it.
> 
> Anton
> 
> --
> 
> On Sat, 2012-03-03 at 08:52 +1100, Benjamin Herrenschmidt wrote:
> 
> > Or give me a chance to dig :-) I'll have a look next week.
> 
> This is indeed what bjorn suspected on irc, this patch fixes it:
> 
> (Bjorn, please fold it in the original offending patch)

Thanks guys; I'll push the fixes to -next when I get to a real network
(at the airport now about to run out of battery with a crappy
connection).

Jesse

Re: 3.3.0-rc6-next-20120308 boot failure on POWER7 blade

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hi Jesse,

On Fri, 9 Mar 2012 10:28:46 -0800 Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> On Fri, 9 Mar 2012 14:46:45 +1100
> Anton Blanchard <anton@samba.org> wrote:
> 
> > > Looks like something that got fixed but the new patches from Bjorn
> > > aren't in next yet. I'll fwd you the patch separately to apply on
> > > top of what you have see if that helps (to confirm that's indeed the
> > > issue).
> > 
> > Thanks, confirmed that it fixes it. Patch below in case anyone else is
> > hitting it.
> > 
> > --
> > 
> > On Sat, 2012-03-03 at 08:52 +1100, Benjamin Herrenschmidt wrote:
> > 
> > > Or give me a chance to dig :-) I'll have a look next week.
> > 
> > This is indeed what bjorn suspected on irc, this patch fixes it:
> > 
> > (Bjorn, please fold it in the original offending patch)
> 
> Thanks guys; I'll push the fixes to -next when I get to a real network
> (at the airport now about to run out of battery with a crappy
> connection).

Ping?

I am also still carrying the build fix for arch/powerpc/kernel/pci-common.c
since Feb 27.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: 3.3.0-rc6-next-20120308 boot failure on POWER7 blade

[Jesse Barnes]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

>Hi Jesse,
>
>On Fri, 9 Mar=
 2012 10:28:46 -0800 Jesse Barnes
><jbarnes@virtuousgeek.org> wrote:
>>
>> =
On Fri, 9 Mar 2012 14:46:45 +1100
>> Anton Blanchard <anton@samba.org> wrot=
e:
>> 
>> > > Looks like something that got fixed but the new patches from
=
>Bjorn
>> > > aren't in next yet. I'll fwd you the patch separately to appl=
y on
>> > > top of what you have see if that helps (to confirm that's indee=
d
>the
>> > > issue).
>> > 
>> > Thanks, confirmed that it fixes it. Patch =
below in case anyone else
>is
>> > hitting it.
>> > 
>> > --
>> > 
>> > On =
Sat, 2012-03-03 at 08:52 +1100, Benjamin Herrenschmidt wrote:
>> > 
>> > > =
Or give me a chance to dig :-) I'll have a look next week.
>> > 
>> > This =
is indeed what bjorn suspected on irc, this patch fixes it:
>> > 
>> > (Bjo=
rn, please fold it in the original offending patch)
>> 
>> Thanks guys; I'l=
l push the fixes to -next when I get to a real
>network
>> (at the airport =
now about to run out of battery with a crappy
>> connection).
>
>Ping?
>
>I=
 am also still carrying the build fix for
>arch/powerpc/kernel/pci-common.c=

>since Feb 27.
>
>-- 
>Cheers,
>Stephen Rothwell                    sfr@ca=
nb.auug.org.au
>http://www.canb.auug.org.au/~sfr/

Arg yeah I'll apply the =
fixups before sending the pull req. This trip has been a nightmare (14+ hou=
r work days and no connectivity and a week longer than expected) but it's f=
inally over, and just in time! 

Jesse
-- 
Jesse Barnes, Intel Open Source =
Technology Center