From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mai La <mla@apm.com>
Cc: Michael Neuling <mikey@neuling.org>,
open-source-review@apm.com, Tirumala R Marri <tmarri@apm.com>,
linux-kernel@vger.kernel.org,
Josh Boyer <jwboyer@linux.vnet.ibm.com>,
Anton Blanchard <anton@samba.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board
Date: Fri, 09 Mar 2012 14:35:45 +1100 [thread overview]
Message-ID: <1331264145.3105.56.camel@pasglop> (raw)
In-Reply-To: <1331263072-9612-1-git-send-email-mla@apm.com>
On Fri, 2012-03-09 at 10:17 +0700, Mai La wrote:
> This patch consists of:
> - Enable PCI MSI as default for Bluestone board
> - Define number of MSI interrupt for Maui APM821xx SoC using in Bluestone board
> - Fix returning ENODEV as finding MSI node
> - Fix MSI physical high and low address
> - Keep MSI data logically
>
> Signed-off-by: Mai La <mla@apm.com>
> ---
> index 7b4df37..c86231e 100644
> --- a/arch/powerpc/sysdev/Kconfig
> +++ b/arch/powerpc/sysdev/Kconfig
> @@ -20,6 +20,12 @@ config PPC_MSI_BITMAP
> default y if FSL_PCI
> default y if PPC4xx_MSI
>
> +config PPC4xx_NR_MSI_IRQS
> + int "Number of PCI MSI interrupts"
> + depends on PCI_MSI && PPC4xx_MSI
> + default "4" if !APM821xx
> + default "8" if APM821xx
> +
.../...
> +#define NR_MSI_IRQS CONFIG_PPC4xx_NR_MSI_IRQS
ARGH.
We asked to -NOT MAKE THIS A COMPILE TIME OPTION-
CONFIG_foo is as bad as your previous ifdef, in fact you just added a
useless config option here.
Make that number dynamic. Count the entries in the device-tree (or add
a property with the number in it, whatever you fancy the most) but make
it something detected at RUNTIME !!!!!
Ben.
next prev parent reply other threads:[~2012-03-09 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 3:17 [PATCH 1/2] powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board Mai La
2012-03-09 3:35 ` Benjamin Herrenschmidt [this message]
2012-03-09 11:40 ` Josh Boyer
-- strict thread matches above, loose matches on Subject: below --
2012-03-12 4:01 Mai La
2012-03-12 5:31 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331264145.3105.56.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mla@apm.com \
--cc=open-source-review@apm.com \
--cc=paulus@samba.org \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).