From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5E4EFB6FD3 for ; Thu, 22 Mar 2012 12:50:15 +1100 (EST) Message-ID: <1332381004.2982.65.camel@pasglop> Subject: Re: [PATCH 14/17] powerpc: crypto: nx driver code supporting nx encryption From: Benjamin Herrenschmidt To: Greg KH Date: Thu, 22 Mar 2012 12:50:04 +1100 In-Reply-To: <20120321221517.GB30748@kroah.com> References: <1332365297.3858.5.camel@key-ThinkPad-W510> <1332366068.3858.50.camel@key-ThinkPad-W510> <20120321221517.GB30748@kroah.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Kent Yoder , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, rcj@linux.vnet.ibm.com, linux-crypto@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2012-03-21 at 15:15 -0700, Greg KH wrote: > > Really? vio drivers are supposed to look like this with the .name and > .owner field manually being set in the static initialization of the > driver? That's sad, and should be fixed, the vio core should do this > type of thing for you. Yeah, they still do it the old way, nobody got to fix that yet, should be pretty easy though. Cheers, Ben.