From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 20B36B6ED0 for ; Thu, 29 Mar 2012 19:11:42 +1100 (EST) Message-ID: <1333008684.3010.9.camel@pasglop> Subject: Re: [GIT PULL] Disintegrate and kill asm/system.h From: Benjamin Herrenschmidt To: Linus Torvalds Date: Thu, 29 Mar 2012 19:11:24 +1100 In-Reply-To: References: <5599.1332958811@redhat.com> <30702.1332989444@neuling.org> <20120329135555.06593144b65bf81cc9191f8a@canb.auug.org.au> <20120329151544.ef2117821dfb459e8b52af48@canb.auug.org.au> <20120329154238.1ce219f7c998da45452af4b2@canb.auug.org.au> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linux-arch@vger.kernel.org, Stephen Rothwell , Michael Neuling , arnd@arndb.de, linux-kernel@vger.kernel.org, David Howells , paul.gortmaker@windriver.com, hpa@zytor.com, akpm@linux-foundation.org, ppc-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2012-03-28 at 22:02 -0700, Linus Torvalds wrote: > On Wed, Mar 28, 2012 at 9:42 PM, Stephen Rothwell wrote: > > > > How about this (build tested on powerpc allyesconfig): > > Looks better. > > Grant - what's the plan about that CONFIG_VIRQ_DEBUG thing? In theory > something like it could be useful as a generic thing, but at least > right now it is clearly powerpc-specific (not just that the config > option only exists for powerpc: it has that whole > 'powerpc_debugfs_root' thing in it)? > > Stephen's patch very much looks like the right thing, but if there was > some plan to actually make this generic ... Yes, as I said earlier I think Grant should make it generic, there's no reason to keep that powerpc specific, it's fairly useful and nothing in userspace relies on the existing location of the debugfs file that I know about. Another option is to put the mapping information in /proc/interrupts but worry that changing anything in there (like adding a column) will break countless userspace tools. Cheers, Ben.