From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.pripojeni.net (mail.pripojeni.net [178.22.112.14]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 198B7B6FC3 for ; Mon, 2 Apr 2012 22:02:13 +1000 (EST) From: Jiri Slaby To: gregkh@linuxfoundation.org Subject: [PATCH 43/69] TTY: hvsi, CLOCAL is not in tty->flags Date: Mon, 2 Apr 2012 13:54:27 +0200 Message-Id: <1333367693-3244-44-git-send-email-jslaby@suse.cz> In-Reply-To: <1333367693-3244-1-git-send-email-jslaby@suse.cz> References: <1333367693-3244-1-git-send-email-jslaby@suse.cz> Cc: jirislaby@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, alan@linux.intel.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , It is in termios cflags. So change the test in hvsi_recv_control to do the right thing. Previously it was actually testing TTY_LDISC_OPEN bit, i.e. whether an ldisc is active. And yes, it is most of the time. Signed-off-by: Jiri Slaby Cc: linuxppc-dev@lists.ozlabs.org --- drivers/tty/hvc/hvsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c index a7488b7..4006aed 100644 --- a/drivers/tty/hvc/hvsi.c +++ b/drivers/tty/hvc/hvsi.c @@ -248,7 +248,7 @@ static void hvsi_recv_control(struct hvsi_struct *hp, uint8_t *packet, pr_debug("hvsi%i: CD dropped\n", hp->index); hp->mctrl &= TIOCM_CD; /* If userland hasn't done an open(2) yet, hp->tty is NULL. */ - if (hp->tty && !(hp->tty->flags & CLOCAL)) + if (hp->tty && !C_CLOCAL(hp->tty)) *to_hangup = hp->tty; } break; -- 1.7.9.2