From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.southpole.se (mail.southpole.se [193.12.106.18]) by ozlabs.org (Postfix) with ESMTP id A55F4B6FD3 for ; Mon, 16 Apr 2012 18:15:02 +1000 (EST) Message-ID: <1334562822.2953.45.camel@crucifix> Subject: Re: [ORLinux] [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h From: Jonas Bonn To: Linus Walleij Date: Mon, 16 Apr 2012 09:53:42 +0200 In-Reply-To: References: <1334483574-3997-1-git-send-email-broonie@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linux-arch@vger.kernel.org, Grant Likely , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, Linus Walleij , Chris Zankel , microblaze-uclinux@itee.uq.edu.au, Mark Brown , linux-kernel@vger.kernel.org, linux@lists.openrisc.net, sparclinux@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org list" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Acked-by: Jonas Bonn (for OpenRISC) On Mon, 2012-04-16 at 09:21 +0200, Linus Walleij wrote: > On Sun, Apr 15, 2012 at 11:52 AM, Mark Brown > wrote: > > > Rather than requiring architectures that use gpiolib but don't have any > > need to define anything custom to copy an asm/gpio.h provide a Kconfig > > symbol which architectures must select in order to include gpio.h and > > for other architectures just provide the trivial implementation directly. > > > > This makes it much easier to do gpiolib updates and is also a step towards > > making gpiolib APIs available on every architecture. > > > > For architectures with existing boilerplate code leave a stub header in > > place which warns on direct inclusion of asm/gpio.h and includes > > linux/gpio.h to catch code that's doing this. Direct inclusion of > > asm/gpio.h has long been deprecated. > > > > Signed-off-by: Mark Brown > > --- > > arch/alpha/include/asm/gpio.h | 59 ++---------------------------- > > arch/arm/Kconfig | 1 + > > arch/avr32/Kconfig | 1 + > > arch/blackfin/Kconfig | 1 + > > arch/ia64/include/asm/gpio.h | 59 ++---------------------------- > > arch/m68k/Kconfig.cpu | 1 + > > arch/microblaze/include/asm/gpio.h | 57 ++--------------------------- > > arch/mips/Kconfig | 1 + > > arch/openrisc/include/asm/gpio.h | 69 ++--------------------------------- > > arch/powerpc/include/asm/gpio.h | 57 ++--------------------------- > > arch/sh/Kconfig | 1 + > > arch/sparc/include/asm/gpio.h | 40 ++------------------- > > arch/unicore32/Kconfig | 1 + > > arch/x86/include/asm/gpio.h | 57 ++--------------------------- > > arch/xtensa/include/asm/gpio.h | 60 ++----------------------------- > > drivers/gpio/Kconfig | 8 ++++ > > include/linux/gpio.h | 34 +++++++++++++++++ > > 17 files changed, 81 insertions(+), 426 deletions(-) > > This looks good but I think we need to page the alpha, ia64, m68k, microblaze, > openrisc etc subarch maintainers on this patch so they have their say. > > Yours, > Linus Walleij > _______________________________________________ > Linux mailing list > Linux@lists.openrisc.net > http://lists.openrisc.net/listinfo/linux