From: Michael Ellerman <michael@ellerman.id.au>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] irqdomain/powerpc: Fix broken NR_IRQ references
Date: Thu, 19 Apr 2012 10:45:01 +1000 [thread overview]
Message-ID: <1334796301.6791.9.camel@concordia> (raw)
In-Reply-To: <1334607198-18694-2-git-send-email-grant.likely@secretlab.ca>
On Mon, 2012-04-16 at 14:13 -0600, Grant Likely wrote:
> diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
> index d09f3e8..fc9df1a 100644
> --- a/arch/powerpc/platforms/cell/axon_msi.c
> +++ b/arch/powerpc/platforms/cell/axon_msi.c
> @@ -276,9 +276,6 @@ static int axon_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> if (rc)
> return rc;
>
> - /* We rely on being able to stash a virq in a u16 */
Would be nice to move the comment to the hunk below rather than just
deleting it. Otherwise the 65536 looks a bit random.
> - BUILD_BUG_ON(NR_IRQS > 65536);
> -
> list_for_each_entry(entry, &dev->msi_list, list) {
> virq = irq_create_direct_mapping(msic->irq_domain);
> if (virq == NO_IRQ) {
> @@ -392,7 +389,7 @@ static int axon_msi_probe(struct platform_device *device)
> }
> memset(msic->fifo_virt, 0xff, MSIC_FIFO_SIZE_BYTES);
>
> - msic->irq_domain = irq_domain_add_nomap(dn, 0, &msic_host_ops, msic);
> + msic->irq_domain = irq_domain_add_nomap(dn, 65536, &msic_host_ops, msic);
> if (!msic->irq_domain) {
> printk(KERN_ERR "axon_msi: couldn't allocate irq_domain for %s\n",
> dn->full_name);
cheers
next prev parent reply other threads:[~2012-04-19 0:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 20:13 [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller Grant Likely
2012-04-16 20:13 ` [PATCH 2/2] irqdomain/powerpc: Fix broken NR_IRQ references Grant Likely
2012-04-19 0:45 ` Michael Ellerman [this message]
2012-04-19 18:21 ` Grant Likely
2012-04-16 20:13 ` [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller Grant Likely
2012-04-16 23:03 ` Benjamin Herrenschmidt
2012-04-16 23:21 ` Grant Likely
2012-04-17 0:03 ` Joakim Tjernlund
2012-04-17 1:00 ` Benjamin Herrenschmidt
2012-04-17 5:33 ` Joakim Tjernlund
2012-04-16 23:03 ` Benjamin Herrenschmidt
2012-04-16 23:23 ` Grant Likely
2012-04-19 18:22 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334796301.6791.9.camel@concordia \
--to=michael@ellerman.id.au \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).