From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 30E10B6FAA for ; Wed, 25 Apr 2012 18:38:57 +1000 (EST) Message-ID: <1335343125.21961.33.camel@pasglop> Subject: Re: [PATCH 00/15] PowerMac i2c API conversions & windfarm updates From: Benjamin Herrenschmidt To: Andreas Schwab Date: Wed, 25 Apr 2012 18:38:45 +1000 In-Reply-To: References: <1334823416-9138-1-git-send-email-benh__1987.51832726902$1334826600$gmane$org@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: khali@linux-fr.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2012-04-25 at 10:00 +0200, Andreas Schwab wrote: > Benjamin Herrenschmidt writes: > > > The biggest change is that windfarm is ported to generally use > > the new model, and I've written a new set of windfarm modules to > > take over from the old therm_pm72 (which was mostly unfixable) > > on the PowerMac G5 AGP and Xserve G5 machines. > > I have the impression that the new driver keeps the fans running faster > all the time. There's a few things you can try. Both drivers put the various values & speeds in sysfs, tho in different places. You can do a test such as overnight idle or something like that and compare the averages. Also, does the new driver properly react to load ? The algorithm should be identical and the factors fed to it as well, but there's always the possibility that I screwed up something. Cheers, Ben.