From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: khali@linux-fr.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 00/15] PowerMac i2c API conversions & windfarm updates
Date: Thu, 26 Apr 2012 19:19:35 +1000 [thread overview]
Message-ID: <1335431975.21961.75.camel@pasglop> (raw)
In-Reply-To: <m2liliam9w.fsf@igel.home>
On Thu, 2012-04-26 at 11:13 +0200, Andreas Schwab wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > What if you just comment out the tickle code ?
>
> I haven't tried it yet, but I suspect it won't tickle the fcu any more
> since wf_control_set avoids writing an unchanged value (unlike the old
> driver).
Sure, the question is whether that fixes the "annoyance" :-)
I don't think we really need to tickle the FCU as long as we have that
#define set in windfarm_fcu to use the actual fan values rather than the
programmed one.
In fact, can you change that define around and see if it makes it behave
more like therm_pm72 overall ? IE That's the only -known- difference
between the old and new driver (+/- a bug / typo / etc..)
Cheers,
Ben.
next prev parent reply other threads:[~2012-04-26 9:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1334823416-9138-1-git-send-email-benh__1987.51832726902$1334826600$gmane$org@kernel.crashing.org>
2012-04-25 8:00 ` [PATCH 00/15] PowerMac i2c API conversions & windfarm updates Andreas Schwab
2012-04-25 8:38 ` Benjamin Herrenschmidt
2012-04-25 10:29 ` Andreas Schwab
2012-04-25 21:14 ` Benjamin Herrenschmidt
2012-04-25 21:54 ` Andreas Schwab
2012-04-25 21:58 ` Benjamin Herrenschmidt
2012-04-26 9:13 ` Andreas Schwab
2012-04-26 9:19 ` Benjamin Herrenschmidt [this message]
2012-04-26 11:41 ` Andreas Schwab
2012-04-26 22:06 ` Benjamin Herrenschmidt
2012-04-27 7:59 ` Andreas Schwab
2012-04-26 11:43 ` Andreas Schwab
2012-04-26 11:46 ` Andreas Schwab
2012-04-19 8:16 Benjamin Herrenschmidt
2012-04-19 9:37 ` Jean Delvare
2012-04-19 9:36 ` Christian Kujau
2012-04-19 20:59 ` Benjamin Herrenschmidt
[not found] ` <20120419113723.03a24d46__2279.25503063506$1334829915$gmane$org@endymion.delvare>
2012-04-19 10:11 ` Andreas Schwab
2012-04-19 11:02 ` Jean Delvare
[not found] ` <m27gxc2fqq.fsf__16075.0973890119$1334830355$gmane$org@igel.home>
2012-04-19 10:14 ` Andreas Schwab
[not found] ` <m239802flw.fsf__48316.0902433612$1334830569$gmane$org@igel.home>
2012-04-19 10:19 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335431975.21961.75.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=khali@linux-fr.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).