linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: khali@linux-fr.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 00/15] PowerMac i2c API conversions & windfarm updates
Date: Fri, 27 Apr 2012 08:06:39 +1000	[thread overview]
Message-ID: <1335477999.21961.85.camel@pasglop> (raw)
In-Reply-To: <m2ehra67p5.fsf@igel.home>

On Thu, 2012-04-26 at 13:41 +0200, Andreas Schwab wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> 
> > In fact, can you change that define around and see if it makes it behave
> > more like therm_pm72 overall ? IE That's the only -known- difference
> > between the old and new driver (+/- a bug / typo / etc..)
> 
> Yes, that's make the difference for the cpu fan control.  Note that
> MacOS (at least 10.3, which is the only one I have) drives the fans the
> same way as the old driver.

Ok, I'll switch that back then. It seemed more sensible to read the
actual fan values rather than the programmed ones (in fact I wonder if I
can just skip the read alltogether then and use a cached value but that
means I won't be able to detect failed fans...), but if you say it
behaves better, let's keep it the way it was.

As for the tickle, I'm not sure yet how to proceed. I'll look into it,
try various things. We can maybe just remove the tickle but that means
that a completely idle machine might start ramping up as the FCU times
out.

Finally, setting the slot fan from sysfs should be doable reasonably
easily. Stay tuned and thanks a lot for testing ! :-)

Cheers,
Ben.

  reply	other threads:[~2012-04-26 22:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1334823416-9138-1-git-send-email-benh__1987.51832726902$1334826600$gmane$org@kernel.crashing.org>
2012-04-25  8:00 ` [PATCH 00/15] PowerMac i2c API conversions & windfarm updates Andreas Schwab
2012-04-25  8:38   ` Benjamin Herrenschmidt
2012-04-25 10:29     ` Andreas Schwab
2012-04-25 21:14       ` Benjamin Herrenschmidt
2012-04-25 21:54         ` Andreas Schwab
2012-04-25 21:58           ` Benjamin Herrenschmidt
2012-04-26  9:13             ` Andreas Schwab
2012-04-26  9:19               ` Benjamin Herrenschmidt
2012-04-26 11:41                 ` Andreas Schwab
2012-04-26 22:06                   ` Benjamin Herrenschmidt [this message]
2012-04-27  7:59                     ` Andreas Schwab
2012-04-26 11:43                 ` Andreas Schwab
2012-04-26 11:46         ` Andreas Schwab
2012-04-19  8:16 Benjamin Herrenschmidt
2012-04-19  9:37 ` Jean Delvare
2012-04-19  9:36   ` Christian Kujau
2012-04-19 20:59   ` Benjamin Herrenschmidt
     [not found] ` <20120419113723.03a24d46__2279.25503063506$1334829915$gmane$org@endymion.delvare>
2012-04-19 10:11   ` Andreas Schwab
2012-04-19 11:02     ` Jean Delvare
     [not found]   ` <m27gxc2fqq.fsf__16075.0973890119$1334830355$gmane$org@igel.home>
2012-04-19 10:14     ` Andreas Schwab
     [not found]     ` <m239802flw.fsf__48316.0902433612$1334830569$gmane$org@igel.home>
2012-04-19 10:19       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335477999.21961.85.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=khali@linux-fr.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).