From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 48C82B6EF3 for ; Tue, 1 May 2012 07:55:37 +1000 (EST) Message-ID: <1335822926.20866.47.camel@pasglop> Subject: Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets From: Benjamin Herrenschmidt To: David Miller Date: Tue, 01 May 2012 07:55:26 +1000 In-Reply-To: <20120430.134140.1738751315208907289.davem@davemloft.net> References: <1335760199.20866.33.camel@pasglop> <4F9E188E.80503@googlemail.com> <1335763568.20866.37.camel@pasglop> <20120430.134140.1738751315208907289.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: kaffeemonster@googlemail.com, eric.dumazet@gmail.com, matt@ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2012-04-30 at 13:41 -0400, David Miller wrote: > From: Benjamin Herrenschmidt > Date: Mon, 30 Apr 2012 15:26:08 +1000 > > > David, what's the right way to fix that ? > > There is no doubt that sock_fprog is the correct datastructure to use. Ok, so the right fix is to email anybody who posted code using struct bpf_program to fix their code ? :-) My question was more along the lines of should we attempt changing one of the two variants to make them match on BE (since they are in effect compatible on LE), tho of course this could have the usual annoying consequence of breaking the mangled c++ name of the symbol). >>From your reply I assume the answer is no... so that leaves us to chase up users and fix them. Great.... Cheers, Ben.