From: Alex Shi <alex.shi@intel.com>
To: a.p.zijlstra@chello.nl
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, dhowells@redhat.com, paulus@samba.org,
hpa@zytor.com, sparclinux@vger.kernel.org, mingo@kernel.org,
sivanich@sgi.com, x86@kernel.org, greg.pearson@hp.com,
chris.mason@oracle.com, arjan.van.de.ven@intel.com,
mattst88@gmail.com, pjt@google.com, fenghua.yu@intel.com,
seto.hidetoshi@jp.fujitsu.com, cmetcalf@tilera.com,
ak@linux.intel.com, ink@jurassic.park.msu.ru, anton@samba.org,
tglx@linutronix.de, kamezawa.hiroyu@jp.fujitsu.com,
rth@twiddle.net, tony.luck@intel.com,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
ralf@linux-mips.org, lethal@linux-sh.org,
linux-alpha@vger.kernel.org, bob.picco@oracle.com,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net
Subject: [RFC PATCH] sched/numa: do load balance between remote nodes
Date: Wed, 6 Jun 2012 14:52:51 +0800 [thread overview]
Message-ID: <1338965571-9812-1-git-send-email-alex.shi@intel.com> (raw)
commit cb83b629b remove the NODE sched domain and check if the node
distance in SLIT table is farther than REMOTE_DISTANCE, if so, it will
lose the load balance chance at exec/fork/wake_affine points.
But actually, even the node distance is farther than REMOTE_DISTANCE,
Modern CPUs also has QPI like connections, that make memory access is
not too slow between nodes. So above losing on NUMA machine make a
huge performance regression on benchmark: hackbench, tbench, netperf
and oltp etc.
This patch will recover the scheduler behavior to old mode on all my
Intel platforms: NHM EP/EX, WSM EP, SNB EP/EP4S, and so remove the
perfromance regressions. (all of them just has 2 kinds distance, 10 21)
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
kernel/sched/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 39eb601..b2ee41a 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6286,7 +6286,7 @@ static int sched_domains_curr_level;
static inline int sd_local_flags(int level)
{
- if (sched_domains_numa_distance[level] > REMOTE_DISTANCE)
+ if (sched_domains_numa_distance[level] > RECLAIM_DISTANCE)
return 0;
return SD_BALANCE_EXEC | SD_BALANCE_FORK | SD_WAKE_AFFINE;
--
1.7.5.4
next reply other threads:[~2012-06-06 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 6:52 Alex Shi [this message]
2012-06-06 9:01 ` [RFC PATCH] sched/numa: do load balance between remote nodes Peter Zijlstra
2012-06-07 0:33 ` Alex Shi
2012-06-06 10:53 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338965571-9812-1-git-send-email-alex.shi@intel.com \
--to=alex.shi@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=arjan.van.de.ven@intel.com \
--cc=bob.picco@oracle.com \
--cc=chris.mason@oracle.com \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=greg.pearson@hp.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lethal@linux-sh.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mattst88@gmail.com \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=pjt@google.com \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=sivanich@sgi.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).