From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 72D39100955 for ; Wed, 6 Jun 2012 19:24:12 +1000 (EST) Message-ID: <1338974632.2749.87.camel@twins> Subject: Re: [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn() From: Peter Zijlstra To: ananth@in.ibm.com Date: Wed, 06 Jun 2012 11:23:52 +0200 In-Reply-To: <20120606091950.GB6745@in.ibm.com> References: <20120606091950.GB6745@in.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Cc: Srikar Dronamraju , lkml , oleg@redhat.com, Paul Mackerras , Anton Blanchard , Ingo Molnar , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2012-06-06 at 14:49 +0530, Ananth N Mavinakayanahalli wrote: > +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_stru= ct *mm, loff_t vaddr) Don't we traditionally use unsigned long to pass vaddrs?