linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] Make hard_irq_disable() actually hard-disable interrupts
Date: Fri, 15 Jun 2012 16:02:12 +1000	[thread overview]
Message-ID: <1339740132.9220.183.camel@pasglop> (raw)
In-Reply-To: <20120615045139.GA11041@pale.ozlabs.ibm.com>

On Fri, 2012-06-15 at 14:51 +1000, Paul Mackerras wrote:
> At present, hard_irq_disable() does nothing on powerpc because of
> this code in include/linux/interrupt.h:
> 
> #ifndef hard_irq_disable
> #define hard_irq_disable()      do { } while(0)
> #endif
> 
> So we need to make our hard_irq_disable be a macro.
> 
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Paul Mackerras <paulus@samba.org>

Add:

CC: <stable@kernel.org> [v3.4]

Before sending to Linus so it hits stable automagically.

Cheers,
Ben.

> --
>  arch/powerpc/include/asm/hw_irq.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
> index c9aac24..32b394f 100644
> --- a/arch/powerpc/include/asm/hw_irq.h
> +++ b/arch/powerpc/include/asm/hw_irq.h
> @@ -100,6 +100,9 @@ static inline void hard_irq_disable(void)
>  	get_paca()->irq_happened |= PACA_IRQ_HARD_DIS;
>  }
>  
> +/* include/linux/interrupt.h needs hard_irq_disable to be a macro */
> +#define hard_irq_disable	hard_irq_disable
> +
>  /*
>   * This is called by asynchronous interrupts to conditionally
>   * re-enable hard interrupts when soft-disabled after having

      reply	other threads:[~2012-06-15  6:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15  4:51 [PATCH v2] Make hard_irq_disable() actually hard-disable interrupts Paul Mackerras
2012-06-15  6:02 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339740132.9220.183.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).