From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] More fixes for lazy IRQ vs. idle
Date: Tue, 10 Jul 2012 18:26:29 +1000 [thread overview]
Message-ID: <1341908789.2561.16.camel@pasglop> (raw)
In-Reply-To: <1341891538.2561.10.camel@pasglop>
> - hard_irq_disable();
> - if (!lazy_irq_pending())
> + if (prep_irq_for_idle()) {
> cede_processor();
> +#ifdef CONFIG_TRACE_IRQFLAG
this is IRQFLAGS (missing "S"). I'll fix it while I commit, the same
typo is in another place in irq.c as well, I'll commit a fix for that
too and shoot the whole thing to Linus.
> + /* Ensure that H_CEDE returns with IRQs on */
> + WARN_ON(!(mfmsr() & MSR_EE));
> +#endif
> + }
> }
>
> static int dedicated_cede_loop(struct cpuidle_device *dev,
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
prev parent reply other threads:[~2012-07-10 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 3:38 [PATCH] More fixes for lazy IRQ vs. idle Benjamin Herrenschmidt
2012-07-10 6:10 ` Michael Neuling
2012-07-10 7:49 ` Benjamin Herrenschmidt
2012-07-10 8:26 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341908789.2561.16.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).