From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from db3outboundpool.messaging.microsoft.com (db3ehsobe005.messaging.microsoft.com [213.199.154.143]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 90B742C0089 for ; Wed, 11 Jul 2012 19:53:56 +1000 (EST) Subject: Re: [PATCH] powerpc/85xx: Add dts files for P1021RDB-PC board From: Jiucheng Xu To: Kumar Gala In-Reply-To: References: <1341909561-6591-1-git-send-email-Jiucheng.Xu@freescale.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 11 Jul 2012 17:58:09 +0800 Message-ID: <1342000689.7459.179.camel@glenn-desktop> MIME-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2012-07-10 at 06:48 -0500, Kumar Gala wrote: > On Jul 10, 2012, at 3:39 AM, Xu Jiucheng wrote: > > --- > > arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 236 +++++++++++++++++++++++++++++ > > arch/powerpc/boot/dts/p1021rdb-pc_32b.dts | 96 ++++++++++++ > > arch/powerpc/boot/dts/p1021rdb-pc_36b.dts | 96 ++++++++++++ > > arch/powerpc/boot/dts/p1021rdb.dts | 96 ------------ > > arch/powerpc/boot/dts/p1021rdb.dtsi | 236 ----------------------------- > > arch/powerpc/boot/dts/p1021rdb_36b.dts | 96 ------------ > > 6 files changed, 428 insertions(+), 428 deletions(-) > > create mode 100644 arch/powerpc/boot/dts/p1021rdb-pc.dtsi > > create mode 100644 arch/powerpc/boot/dts/p1021rdb-pc_32b.dts > > create mode 100644 arch/powerpc/boot/dts/p1021rdb-pc_36b.dts > > delete mode 100644 arch/powerpc/boot/dts/p1021rdb.dts > > delete mode 100644 arch/powerpc/boot/dts/p1021rdb.dtsi > > delete mode 100644 arch/powerpc/boot/dts/p1021rdb_36b.dts > > Do we really need a 32 & 36 bit device tree for this board? Isnt the memory fixed so why not just have 32b? > I have no idea, 36 bit is already there in the history release of SDK, If it is not necessary for upstream, I can resend a new patch without 36 bit. > Also, why are you removing the dts for the older P1021RDB?? > > - k This dts for the older P1021RDB was committed by me. I just rename these files in order to keep uniformity with other platforms, e.g "P1020rdb-pc.dtsi p1020mbg-pc.dtsi". If you think it doesn't matter, please ignore this patch. If AMP is a specific application as Timur says, please ignore the AMP patch. Thanks, Jiucheng