From: Michael Ellerman <michael@ellerman.id.au>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Robert Jennings <rcj@linux.vnet.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kent Yoder <key@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver
Date: Mon, 30 Jul 2012 18:00:59 +1000 [thread overview]
Message-ID: <1343635259.10666.1.camel@concordia> (raw)
In-Reply-To: <500964A7.1020702@linux.vnet.ibm.com>
On Fri, 2012-07-20 at 09:01 -0500, Seth Jennings wrote:
> On 07/20/2012 12:33 AM, Michael Ellerman wrote:
> > On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote:
> >> This patch adds the driver for interacting with the 842
> >> compression accelerator on IBM Power7+ systems.
> >
> > ...
> >
> >> +struct nx842_slentry {
> >> + unsigned long ptr; /* Absolute address (use virt_to_abs()) */
> >> /+ unsigned long len;
> >> +};
> >
> > These days virt_to_abs() is just __pa() - ie. convert to a real address.
>
> Thanks, I'll make that change.
>
> Is it a blocker to the code being pulled in though? I'm
> hoping to get this in ASAP for the 3.6 merge window. As
> this isn't a functional defect (I assume __pa() and
> virt_to_abs() still achieve the same result), can I get an
> OK from you that this isn't a blocker to the code being
> accepted?
Sorry I missed your reply. No it's not a blocker, just ugly.
I have sent a series to Ben which removes virt_to_abs() entirely, so
we'll want to make sure we fixup the nx driver before that goes in.
cheers
next prev parent reply other threads:[~2012-07-30 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 14:42 [PATCH 0/4] powerpc/crypto: IBM Power7+ in-Nest compression support Seth Jennings
2012-07-19 14:42 ` [PATCH 1/4] powerpc/crypto: rework Kconfig Seth Jennings
2012-07-19 14:42 ` [PATCH 2/4] powerpc/crypto: add compression support to arch vec Seth Jennings
2012-07-19 14:42 ` [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver Seth Jennings
2012-07-20 5:33 ` Michael Ellerman
2012-07-20 14:01 ` Seth Jennings
2012-07-30 8:00 ` Michael Ellerman [this message]
2012-07-19 14:42 ` [PATCH 4/4] powerpc/crypto: add 842 crypto driver Seth Jennings
2012-07-30 7:56 ` [PATCH 0/4] powerpc/crypto: IBM Power7+ in-Nest compression support Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343635259.10666.1.camel@concordia \
--to=michael@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=key@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).