[PATCH] dma/fsldma: fix a compilation warnings

[PATCH] dma/fsldma: fix a compilation warnings

[Kumar Gala]

drivers/dma/fsldma.c: In function 'fsl_dma_tx_submit':
drivers/dma/fsldma.c:409:15: warning: 'cookie' may be used uninitialized in this function

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 drivers/dma/fsldma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 8f84761..6194eb7 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct dma_async_tx_descriptor *tx)
 	struct fsl_desc_sw *desc = tx_to_fsl_desc(tx);
 	struct fsl_desc_sw *child;
 	unsigned long flags;
-	dma_cookie_t cookie;
+	dma_cookie_t cookie = 0;
 
 	spin_lock_irqsave(&chan->desc_lock, flags);
 
-- 
1.7.9.7

RE: [PATCH] dma/fsldma: fix a compilation warnings

[Liu Qiang-B32616]

Hi Kumar,=0A=
________________________________________=0A=
> From: Linuxppc-dev [linuxppc-dev-bounces+qiang.liu=3Dfreescale.com@lists.=
ozlabs.org] on behalf of Kumar Gala [galak@kernel.crashing.org]=0A=
> Sent: Tuesday, July 31, 2012 8:57 AM=0A=
> To: dan.j.williams@intel.com=0A=
> Cc: vinod.koul@intel.com; linuxppc-dev@ozlabs.org=0A=
> Subject: [PATCH] dma/fsldma: fix a compilation warnings=0A=
=0A=
> drivers/dma/fsldma.c: In function 'fsl_dma_tx_submit':=0A=
> drivers/dma/fsldma.c:409:15: warning: 'cookie' may be used uninitialized =
in this function=0A=
> =0A=
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>=0A=
> ---=0A=
>  drivers/dma/fsldma.c |    2 +-=0A=
>  1 file changed, 1 insertion(+), 1 deletion(-)=0A=
> =0A=
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c=0A=
> index 8f84761..6194eb7 100644=0A=
> --- a/drivers/dma/fsldma.c=0A=
> +++ b/drivers/dma/fsldma.c=0A=
> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct dma_asyn=
c_tx_descriptor *tx)=0A=
>        struct fsl_desc_sw *desc =3D tx_to_fsl_desc(tx);=0A=
>        struct fsl_desc_sw *child;=0A=
>         unsigned long flags;=0A=
> -       dma_cookie_t cookie;=0A=
> +       dma_cookie_t cookie =3D 0;=0A=
I have already submitted a patch to fix it. Please refer to:=0A=
https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-July/099819.html=0A=
=0A=
Thanks.=0A=
=0A=
>         spin_lock_irqsave(&chan->desc_lock, flags);=0A=
> =0A=
> --=0A=
> 1.7.9.7=0A=
=0A=
_______________________________________________=0A=
Linuxppc-dev mailing list=0A=
Linuxppc-dev@lists.ozlabs.org=0A=
https://lists.ozlabs.org/listinfo/linuxppc-dev=0A=
=0A=

Re: [PATCH] dma/fsldma: fix a compilation warnings

[Kumar Gala]

On Jul 31, 2012, at 9:48 AM, Liu Qiang-B32616 wrote:

> Hi Kumar,
> ________________________________________
>> From: Linuxppc-dev =
[linuxppc-dev-bounces+qiang.liu=3Dfreescale.com@lists.ozlabs.org] on =
behalf of Kumar Gala [galak@kernel.crashing.org]
>> Sent: Tuesday, July 31, 2012 8:57 AM
>> To: dan.j.williams@intel.com
>> Cc: vinod.koul@intel.com; linuxppc-dev@ozlabs.org
>> Subject: [PATCH] dma/fsldma: fix a compilation warnings
>=20
>> drivers/dma/fsldma.c: In function 'fsl_dma_tx_submit':
>> drivers/dma/fsldma.c:409:15: warning: 'cookie' may be used =
uninitialized in this function
>>=20
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> drivers/dma/fsldma.c |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
>> index 8f84761..6194eb7 100644
>> --- a/drivers/dma/fsldma.c
>> +++ b/drivers/dma/fsldma.c
>> @@ -406,7 +406,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct =
dma_async_tx_descriptor *tx)
>>      struct fsl_desc_sw *desc =3D tx_to_fsl_desc(tx);
>>      struct fsl_desc_sw *child;
>>       unsigned long flags;
>> -       dma_cookie_t cookie;
>> +       dma_cookie_t cookie =3D 0;
> I have already submitted a patch to fix it. Please refer to:
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-July/099819.html
>=20
> Thanks.

Ah, good.. missed it ;)

- k=