From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: B07421@freescale.com, linuxppc-dev@lists.ozlabs.org,
Jia Hongtao <B38951@freescale.com>
Subject: Re: [PATCH V7 1/3] powerpc/pci: Make sure ISA IO base is not zero
Date: Thu, 16 Aug 2012 08:42:55 +1000 [thread overview]
Message-ID: <1345070575.11751.8.camel@pasglop> (raw)
In-Reply-To: <502C1B64.8050505@freescale.com>
On Wed, 2012-08-15 at 16:57 -0500, Scott Wood wrote:
> Is there no lasting remnant of that temporary wrong isa_io_base? We
> won't have I/O resources that were calculated relative to that, which
> stop working once isa_io_base changes? Or does that happen later, after
> this function has been called on all buses (and would that continue to
> be the case if we change the PCI bus to a platform device)?
If you continue creating your PCI busses all at once early on you'll be
fine. The platform device business is going to break that (and other
things as well btw, such as pci_final_fixup).
Maybe it's time to contemplate doing something more like ppc64 and
reserve a piece of virtual address space (I know there isn't much, so
make it 64k per bus max) and just map the busses in there with the first
64k being reserved for the ISA stuff if it exists ?
Cheers,
Ben.
next prev parent reply other threads:[~2012-08-15 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 8:57 [PATCH V7 0/3] PCI unification patch description Jia Hongtao
2012-08-15 8:57 ` [PATCH V7 1/3] powerpc/pci: Make sure ISA IO base is not zero Jia Hongtao
2012-08-15 17:29 ` Scott Wood
2012-08-15 21:32 ` Benjamin Herrenschmidt
2012-08-15 21:57 ` Scott Wood
2012-08-15 22:42 ` Benjamin Herrenschmidt [this message]
2012-08-16 3:37 ` Jia Hongtao-B38951
2012-08-16 3:11 ` Jia Hongtao-B38951
2012-08-15 8:57 ` [PATCH V7 2/3] powerpc/ge_imp3a: Add ISA node to PCI primary bus Jia Hongtao
2012-08-15 17:31 ` Scott Wood
2012-08-15 21:01 ` Kumar Gala
2012-08-15 21:05 ` Scott Wood
2012-08-15 8:57 ` [PATCH V7 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code Jia Hongtao
2012-08-15 17:35 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345070575.11751.8.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B07421@freescale.com \
--cc=B38951@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).