linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: wency@cn.fujitsu.com
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org,
	linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-ia64@vger.kernel.org, cmetcalf@tilera.com
Cc: len.brown@intel.com, Wen Congyang <wency@cn.fujitsu.com>,
	isimatu.yasuaki@jp.fujitsu.com, paulus@samba.org,
	minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com,
	rientjes@google.com, cl@linux.com, akpm@linux-foundation.org,
	liuj97@gmail.com
Subject: [RFC V7 PATCH 18/19] memory-hotplug: add node_device_release
Date: Mon, 20 Aug 2012 17:35:41 +0800	[thread overview]
Message-ID: <1345455342-27752-19-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1345455342-27752-1-git-send-email-wency@cn.fujitsu.com>

From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

When calling unregister_node(), the function shows following message at
device_release().

Device 'node2' does not have a release() function, it is broken and must be
fixed.

So the patch implements node_device_release()

CC: David Rientjes <rientjes@google.com>
CC: Jiang Liu <liuj97@gmail.com>
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
 drivers/base/node.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index af1a177..9bc2f57 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -252,6 +252,13 @@ static inline void hugetlb_register_node(struct node *node) {}
 static inline void hugetlb_unregister_node(struct node *node) {}
 #endif
 
+static void node_device_release(struct device *dev)
+{
+	struct node *node_dev = to_node(dev);
+
+	flush_work(&node_dev->node_work);
+	memset(node_dev, 0, sizeof(struct node));
+}
 
 /*
  * register_node - Setup a sysfs device for a node.
@@ -265,6 +272,7 @@ int register_node(struct node *node, int num, struct node *parent)
 
 	node->dev.id = num;
 	node->dev.bus = &node_subsys;
+	node->dev.release = node_device_release;
 	error = device_register(&node->dev);
 
 	if (!error){
-- 
1.7.1

  parent reply	other threads:[~2012-08-20  9:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  9:35 [RFC V7 PATCH 00/19] memory-hotplug: hot-remove physical memory wency
2012-08-20  9:35 ` [RFC V7 PATCH 01/19] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages() wency
2012-08-20  9:35 ` [RFC V7 PATCH 02/19] memory-hotplug: implement offline_memory() wency
2012-08-20  9:35 ` [RFC V7 PATCH 03/19] memory-hotplug: store the node id in acpi_memory_device wency
2012-08-20  9:35 ` [RFC V7 PATCH 04/19] memory-hotplug: offline and remove memory when removing the memory device wency
2012-08-20  9:35 ` [RFC V7 PATCH 05/19] memory-hotplug: check whether memory is present or not wency
2012-08-20  9:35 ` [RFC V7 PATCH 06/19] memory-hotplug: export the function acpi_bus_remove() wency
2012-08-20  9:35 ` [RFC V7 PATCH 07/19] memory-hotplug: call acpi_bus_remove() to remove memory device wency
2012-08-20  9:35 ` [RFC V7 PATCH 08/19] memory-hotplug: remove /sys/firmware/memmap/X sysfs wency
2012-08-20  9:35 ` [RFC V7 PATCH 09/19] memory-hotplug: does not release memory region in PAGES_PER_SECTION chunks wency
2012-08-20  9:35 ` [RFC V7 PATCH 10/19] memory-hotplug: add memory_block_release wency
2012-08-20  9:35 ` [RFC V7 PATCH 11/19] memory-hotplug: remove_memory calls __remove_pages wency
2012-08-20  9:35 ` [RFC V7 PATCH 12/19] memory-hotplug: introduce new function arch_remove_memory() wency
2012-08-20  9:35 ` [RFC V7 PATCH 13/19] memory-hotplug: check page type in get_page_bootmem wency
2012-08-20  9:35 ` [RFC V7 PATCH 14/19] memory-hotplug: move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmap wency
2012-08-20  9:35 ` [RFC V7 PATCH 15/19] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap wency
2012-08-20  9:35 ` [RFC V7 PATCH 16/19] memory-hotplug: free memmap " wency
2012-08-20  9:35 ` [RFC V7 PATCH 17/19] memory_hotplug: clear zone when the memory is removed wency
2012-08-20  9:35 ` wency [this message]
2012-08-20 14:09   ` [RFC V7 PATCH 18/19] memory-hotplug: add node_device_release Jianguo Wu
2012-08-20  9:35 ` [RFC V7 PATCH 19/19] memory-hotplug: remove sysfs file of node wency

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345455342-27752-19-git-send-email-wency@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=cmetcalf@tilera.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=liuj97@gmail.com \
    --cc=minchan.kim@gmail.com \
    --cc=paulus@samba.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).