From: Dan Williams <djbw@fb.com>
To: Liu Qiang-B32616 <B32616@freescale.com>
Cc: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"arnd@arndb.de" <arnd@arndb.de>,
"Ira W. Snyder" <iws@ovro.caltech.edu>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance
Date: Wed, 29 Aug 2012 07:52:55 -0700 [thread overview]
Message-ID: <1346251975.27020.2.camel@localhost.localdomain> (raw)
In-Reply-To: <BCB48C05FCE8BC4D9E61E841ECBE6DB70FC3CA@039-SN2MPN1-011.039d.mgd.msft.net>
On Wed, 2012-08-29 at 11:15 +0000, Liu Qiang-B32616 wrote:
> Hi Dan,
>
> Ping?
> Can you apply these patches? Thanks.
>
I'm working my way through them.
The first thing I notice is that xor_chan->desc_lock is taken
inconsistently. I.e. spin_lock_irqsave() in talitos_process_pending()
and spin_lock_bh() everywhere else. Have you run these patches with
lockdep?
--
Dan
next prev parent reply other threads:[~2012-08-29 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 8:19 [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance qiang.liu
2012-08-09 17:03 ` Ira W. Snyder
2012-08-14 9:04 ` Liu Qiang-B32616
2012-08-14 20:01 ` Dan Williams
2012-08-15 7:59 ` Liu Qiang-B32616
2012-08-29 11:15 ` Liu Qiang-B32616
2012-08-29 14:52 ` Dan Williams [this message]
2012-08-30 6:20 ` Liu Qiang-B32616
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346251975.27020.2.camel@localhost.localdomain \
--to=djbw@fb.com \
--cc=B32616@freescale.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=iws@ovro.caltech.edu \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).