From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2600B2C00C3 for ; Thu, 30 Aug 2012 01:26:10 +1000 (EST) Message-ID: <1346251975.27020.2.camel@localhost.localdomain> Subject: Re: [PATCH v7 0/8] Raid: enable talitos xor offload for improving performance From: Dan Williams To: Liu Qiang-B32616 Date: Wed, 29 Aug 2012 07:52:55 -0700 In-Reply-To: References: <1344500375-8457-1-git-send-email-qiang.liu@freescale.com> <20120809170307.GG14264@ovro.caltech.edu> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: "herbert@gondor.apana.org.au" , "arnd@arndb.de" , "Ira W. Snyder" , "vinod.koul@intel.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2012-08-29 at 11:15 +0000, Liu Qiang-B32616 wrote: > Hi Dan, > > Ping? > Can you apply these patches? Thanks. > I'm working my way through them. The first thing I notice is that xor_chan->desc_lock is taken inconsistently. I.e. spin_lock_irqsave() in talitos_process_pending() and spin_lock_bh() everywhere else. Have you run these patches with lockdep? -- Dan