From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: [PATCH 00/22 V4] powerpc/eeh: PE support
Date: Sat, 8 Sep 2012 16:44:01 +0800 [thread overview]
Message-ID: <1347093863-6319-1-git-send-email-shangw@linux.vnet.ibm.com> (raw)
The series of patches address explicit PE support as well as probe type
support. For explicit PE support, struct eeh_pe has been introduced.
While designing the struct, following factors have been taken into
account.
* For one particular PE, it might be composed of single PCI device,
or multiple PCI devices and its educed children PCI devices (e.g.
by PCIe bridges). The PE struct has included a linked list to refer
the included PCI devices. Also, the linked list of devices has relected
top-to-bottom fasion of the PCI subtree. That's to say, the first device
in the linked list should be the toppest element in the PCI subtree which
is being managed by the PE.
* PEs correlate to each other. So the existing PEs have to form hierarchy
levels. There're some fields in PE struct (e.g. parent/child/silbing)
have been introduced for the purpose.
* For one PE, it's only meaningful in the PHB domain.
In addition, the mechniasm used to do memory bars restore, error report have
been reworked based on PE. The eeh cache has been reworked for a little bit
based on Ben's suggestion to trace eeh device.
In order for explicit probe support, either OF node or pci device, global
variable and some inline functions are introduced. For pSeries platform, it's
going to support OF node probe and figure out PEs from the corresponding OF
nodes. In contrast, powernv platform has to use pci device probe type since
the PEs are being constructed at PHB fixup time.
The series of patches have been verified on Firebird-L machine using "errinjct"
utility. Here's the command used for that.
errinjct eeh -v -f 0 -p U78AE.001.WZS00M9-P1-C18-L1-T2 -a 0x0 -m 0x0
V3 -> V4:
* The V4 patches were built on 3.6.RC4 as V3 did.
* Changelog changes according to Ben's comments. More specificly,
change FDT with device tree or similiar terminology.
* Print return value when failing to register platform dependent EEH
operations in eeh_pseries_init().
* Introduce function eeh_pe_alloc() to allocate instance of EEH PE
and initialize its link lists. The PE type and corresponding PHB
are also assigned during PE creation time.
* Change eeh_phb_pe_create() to use eeh_pe_alloc().
* Introduce function eeh_add_to_parent_pe() to replace the original
function eeh_pe_create().
* Change pr_info() to pr_debug() while associating EEH device with its
parent PE to reduce output from system console.
* Rename eeh_pe_remove() to eeh_rmv_from_parent_pe().
* Change pr_err() to pr_warning() when we can't find the parent PE for
the given EEH device in eeh_rmv_from_parent_pe().
* Fix the experssion to check if the given PE is PHB sensitive PE in
function eeh_rmv_from_parent_pe().
* Rename EEH_PROBE_MODE_FDT to EEH_PROBE_MODE_DEVTREE.
* Rename function eeh_probe_mode_fdt() to eeh_probe_mode_devtree().
* Cleanup on function names for EEH cache so that they have prefix "eeh"
and more short. Besides, the printk() has been replaced with pr_warning()
or pr_debug().
V2 -> V3:
* Rebase to 3.6.RC4.
V1 -> V2:
* Rebase to 3.5.RC4.
* Use the link list to trace the relationships of PEs, PE and eeh
devices according to Ram's suggestion.
* Simplify the PE tranverse function according to Ram's example.
* Move EEH initialization around according to Ben's suggestion so
that we can do memory allocation through slab.
* Use kzmalloc() to allocate memory chunks for PE and eeh devices.
* More booting messages for EEH initialization functions.
* Introduce global EEH mutex to protect the PEs and eeh devices.
* Added functions to support PE removal.
* Comments cleanup
* Change on the comparison of PE or BDF (Bus/Device/Function)
address so that code looks more readable.
-----
arch/powerpc/include/asm/eeh.h | 136 +++++--
arch/powerpc/include/asm/eeh_event.h | 6 +-
arch/powerpc/include/asm/pci-bridge.h | 2 +
arch/powerpc/include/asm/ppc-pci.h | 20 +-
arch/powerpc/kernel/rtas_pci.c | 5 +-
arch/powerpc/platforms/pseries/Makefile | 5 +-
arch/powerpc/platforms/pseries/eeh.c | 531 +++++------------------
arch/powerpc/platforms/pseries/eeh_cache.c | 57 ++--
arch/powerpc/platforms/pseries/eeh_dev.c | 14 +-
arch/powerpc/platforms/pseries/eeh_driver.c | 235 +++++------
arch/powerpc/platforms/pseries/eeh_event.c | 54 +--
arch/powerpc/platforms/pseries/eeh_pe.c | 591 ++++++++++++++++++++++++++
arch/powerpc/platforms/pseries/eeh_pseries.c | 247 ++++++++----
arch/powerpc/platforms/pseries/eeh_sysfs.c | 9 -
arch/powerpc/platforms/pseries/msi.c | 6 +-
arch/powerpc/platforms/pseries/pci.c | 2 +-
arch/powerpc/platforms/pseries/setup.c | 2 -
17 files changed, 1154 insertions(+), 768 deletions(-)
create mode 100644 arch/powerpc/platforms/pseries/eeh_pe.c
Thanks,
Gavin
next reply other threads:[~2012-09-08 8:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 8:44 Gavin Shan [this message]
2012-09-08 8:44 ` [PATCH 01/22] ppc/eeh: move EEH initialization around Gavin Shan
2012-09-08 8:44 ` [PATCH 02/22] ppc/eeh: use slab to allocate eeh devices Gavin Shan
2012-09-08 8:44 ` [PATCH 03/22] ppc/eeh: more logs for EEH initialization Gavin Shan
2012-09-08 8:44 ` [PATCH 04/22] ppc/eeh: Introduce eeh_pe struct Gavin Shan
2012-09-08 8:44 ` [PATCH 05/22] ppc/eeh: introduce global mutex Gavin Shan
2012-09-08 8:44 ` [PATCH 06/22] ppc/eeh: Create PEs for PHBs Gavin Shan
2012-09-08 8:44 ` [PATCH 07/22] ppc/eeh: Search PE based on requirement Gavin Shan
2012-09-08 8:44 ` [PATCH 08/22] ppc/eeh: create PEs duing EEH initialization Gavin Shan
2012-09-08 8:44 ` [PATCH 09/22] ppc/eeh: remove PE at appropriate time Gavin Shan
2012-09-08 8:44 ` [PATCH 10/22] ppc/eeh: build EEH event based on PE Gavin Shan
2012-09-08 8:44 ` [PATCH 11/22] ppc/eeh: trace EEH state " Gavin Shan
2012-09-08 8:44 ` [PATCH 12/22] ppc/eeh: trace error based on PE from beginning Gavin Shan
2012-09-08 8:44 ` [PATCH 13/22] ppc/eeh: eeh options based on PE Gavin Shan
2012-09-08 8:44 ` [PATCH 14/22] ppc/eeh: device bars restore " Gavin Shan
2012-09-08 8:44 ` [PATCH 15/22] ppc/eeh: I/O enable and log retrival " Gavin Shan
2012-09-08 8:44 ` [PATCH 16/22] ppc/eeh: do reset " Gavin Shan
2012-09-08 8:44 ` [PATCH 17/22] ppc/eeh: make EEH handler PE sensitive Gavin Shan
2012-09-08 8:44 ` [PATCH 18/22] ppc/eeh: handle EEH error based on PE Gavin Shan
2012-09-08 8:44 ` [PATCH 19/22] ppc/eeh: move stats to PE Gavin Shan
2012-09-08 8:44 ` [PATCH 20/22] ppc/eeh: probe mode support Gavin Shan
2012-09-08 8:44 ` [PATCH 21/22] ppc/eeh: trace eeh device from I/O cache Gavin Shan
2012-09-08 8:44 ` [PATCH 22/22] ppc/eeh: cleanup on EEH PCI address cache Gavin Shan
2012-09-09 23:59 ` Benjamin Herrenschmidt
2012-09-10 0:04 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347093863-6319-1-git-send-email-shangw@linux.vnet.ibm.com \
--to=shangw@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).