From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bharat Bhushan <r65777@freescale.com>
Cc: scottwood@freescale.com,
Bharat Bhushan <bharat.bhushan@freescale.com>,
linuxppc-dev@lists.ozlabs.org, agraf@suse.de
Subject: Re: [PATCH] using get/put_user64 apis on 64bit machine
Date: Mon, 10 Sep 2012 14:42:09 +1000 [thread overview]
Message-ID: <1347252129.2385.147.camel@pasglop> (raw)
In-Reply-To: <1343038597-23859-1-git-send-email-Bharat.Bhushan@freescale.com>
On Mon, 2012-07-23 at 15:46 +0530, Bharat Bhushan wrote:
> On powerpc64 machine get/put_user64() is same as get/put_user() while
> on powerpc32 machine get_user64 is different. With this patch we can
> use get_user64() and put_user64() on 32 and 64 bit machines.
>
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
> ---
There appear to be no user of any of these APIs in the tree. There's
also no get_user64 -> __get_user64() macros either. Why not just remove
the whole lot ?
Cheers,
Ben.
> arch/powerpc/include/asm/uaccess.h | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h
> index 17bb40c..01743aa 100644
> --- a/arch/powerpc/include/asm/uaccess.h
> +++ b/arch/powerpc/include/asm/uaccess.h
> @@ -114,10 +114,17 @@ struct exception_table_entry {
> #define __put_user(x, ptr) \
> __put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
>
> +/*
> + * On powerpc64 machine get/put_user64() is same as get/put_user() while
> + * on powerpc32 machine get_user64 is different.
> + */
> #ifndef __powerpc64__
> #define __get_user64(x, ptr) \
> __get_user64_nocheck((x), (ptr), sizeof(*(ptr)))
> #define __put_user64(x, ptr) __put_user(x, ptr)
> +#else
> +#define __get_user64(x, ptr) __get_user(x, ptr)
> +#define __put_user64(x, ptr) __put_user(x, ptr)
> #endif
>
> #define __get_user_inatomic(x, ptr) \
next prev parent reply other threads:[~2012-09-10 4:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 10:16 [PATCH] using get/put_user64 apis on 64bit machine Bharat Bhushan
2012-09-10 4:42 ` Benjamin Herrenschmidt [this message]
2012-09-10 8:50 ` Bhushan Bharat-R65777
2012-09-10 22:25 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347252129.2385.147.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=bharat.bhushan@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r65777@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).