From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Haren Myneni <haren@linux.vnet.ibm.com>
Cc: paulus@samba.org, Michael Neuling <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org, anton@samba.org
Subject: Re: [PATCH 2/6] powerpc: Add enable_ppr kernel parameter to enable PPR save/restore
Date: Tue, 11 Sep 2012 15:55:11 +1000 [thread overview]
Message-ID: <1347342911.2603.39.camel@pasglop> (raw)
In-Reply-To: <504ECF35.9070305@linux.vnet.ibm.com>
On Mon, 2012-09-10 at 22:42 -0700, Haren Myneni wrote:
>
> Thanks Michael. Yes, we noticed 6% overhead with null syscall test.
> Hence added cmdline option as suggested. I will add this comment in
> the
> changelog.
>
> Regarding the option name, I thought about various ones such as
> retain_process_ppr, retain_smt_priority, save_ppr and etc. Finally
> added
> 'enable_ppr' since it enables CPU_FTR (CPU_FTR_HAS_PPR) which allows
> to
> save/restore PPR value. Sure, I will change this option.
No, that isn't a problem with the name. It's a problem with the polarity
of the option.
If you need a command line argument to enable the option, then nobody
will enable it, it's pointless.
Cheers,
Ben.
next prev parent reply other threads:[~2012-09-11 5:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 11:37 [PATCH 2/6] powerpc: Add enable_ppr kernel parameter to enable PPR save/restore Haren Myneni
2012-09-10 0:12 ` Benjamin Herrenschmidt
2012-09-10 0:22 ` Michael Neuling
2012-09-11 5:42 ` Haren Myneni
2012-09-11 5:55 ` Benjamin Herrenschmidt [this message]
2012-09-28 22:11 ` Ryan Arnold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347342911.2603.39.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=haren@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).