From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "tiejun.chen" <tiejun.chen@windriver.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [v3][PATCH 2/3] ppc/kprobe: complete kprobe and migrate exception frame
Date: Wed, 12 Sep 2012 18:43:02 +1000 [thread overview]
Message-ID: <1347439382.2603.97.camel@pasglop> (raw)
In-Reply-To: <505049FE.8060204@windriver.com>
On Wed, 2012-09-12 at 16:38 +0800, tiejun.chen wrote:
> > So you need to store that old r1 somewhere fist then retrieve it
> > after the memcpy call. That or open-code the memcpy to avoid all
> > the clobbering problems.
>
> Maybe we can use copy_and_flush() since looks copy_and_flush() only
> clobber r0,
> r6 and LR explicitly.
>
> I'll resync these comments for v4.
I'd say just open code it. You already have src and dst in registers,
the length can easily be put in ctr... easier that way, not clobbering
to worry about nor stack frame to create etc...
Cheers,
Ben.
next prev parent reply other threads:[~2012-09-12 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 2:20 [v3][PATCH 1/3] powerpc/kprobe: introduce a new thread flag Tiejun Chen
2012-09-11 2:20 ` [v3][PATCH 2/3] ppc/kprobe: complete kprobe and migrate exception frame Tiejun Chen
2012-09-11 5:51 ` Benjamin Herrenschmidt
2012-09-12 8:38 ` tiejun.chen
2012-09-12 8:43 ` Benjamin Herrenschmidt [this message]
2012-09-12 8:55 ` tiejun.chen
2012-09-12 10:38 ` Benjamin Herrenschmidt
2012-09-13 10:36 ` tiejun.chen
2012-09-13 21:42 ` Benjamin Herrenschmidt
2012-09-11 2:20 ` [v3][PATCH 3/3] ppc/kprobe: don't emulate store when kprobe stwu r1 Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347439382.2603.97.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).