From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Dennis Schridde <devurandom@gmx.net>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: PROBLEM: Linux 3.6.2 fails to boot on IBM Cell
Date: Fri, 19 Oct 2012 10:25:39 +1100 [thread overview]
Message-ID: <1350602739.2476.18.camel@pasglop> (raw)
In-Reply-To: <CACxGe6uehfQZOxhtBfUYR47mQq+620A=pvpRM=9O8FoUX9eg7w@mail.gmail.com>
On Thu, 2012-10-18 at 23:44 +0100, Grant Likely wrote:
> Also, it should be noted that the irq does actually get set up by
> irqdomain.c, but because everything above 0x1ff is larger than the
> lookup table, it complains. The new code complains loudly (as you
> discovered) if someone tries to use a hwirq larger than the map where
> the old code didn't.
>
> Looks to me like the fix is to change for_each_node() to something as
> simple as "for (i = 0; i < 2; i++)"
I think somebody was expecting for_each_node() to iterate only present
nodes or something ... Not all Cell systems have both nodes btw, so we
might want to be a tiny bit smarter than that .... or not :-)
Cheers,
Ben.
prev parent reply other threads:[~2012-10-18 23:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5521875.6lkx8Qvfk5@ernie>
[not found] ` <2594570.cnhHoOP5cq@ernie>
[not found] ` <CACxGe6tdpCiZtpvrb7VUz9=mc6DqG6wO-Z5axaBMzuU2Y14GmA@mail.gmail.com>
[not found] ` <3999612.yr3XeWjcOk@ernie>
2012-10-18 22:44 ` PROBLEM: Linux 3.6.2 fails to boot on IBM Cell Grant Likely
2012-10-18 22:59 ` Grant Likely
2012-10-18 23:17 ` Grant Likely
2012-10-19 7:04 ` Dennis Schridde
2012-10-25 19:33 ` Dennis Schridde
2012-11-15 16:13 ` Dennis Schridde
2012-11-15 17:58 ` Grant Likely
2012-12-24 13:39 ` Dennis Schridde
2013-04-21 12:31 ` Dennis Schridde
2012-10-18 23:25 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350602739.2476.18.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=devurandom@gmx.net \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).