linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: sachin.surendran@gmail.com
To: galak@kernel.crashing.org, jochen@scram.de
Cc: Sachin Surendran <sachin.surendran@alliedtelesis.co.nz>,
	sachin.surendran@gmail.com, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 1/1] i2c-cpm: Fix to takeback i2c bus master-ship after a collision
Date: Mon, 26 Nov 2012 11:20:01 +1300	[thread overview]
Message-ID: <1353882001-30744-1-git-send-email-sachin.surendran@gmail.com> (raw)
In-Reply-To: <sachin.surendran@gmail.com>

From: Sachin Surendran <sachin.surendran@alliedtelesis.co.nz>

In case of collision on i2c bus the controller which lost bus mastership
stays as a slave for all subsequent transfers. This results in the i2c
controller never writing to the bus for future transactions, resulting
in i2c transfer timeouts.
  This fix checks for a collision on last I2C transaction and sets the
I2COM_MASTER bit for the new transaction.

Signed-off-by: Sachin Surendran <sachin.surendran@alliedtelesis.co.nz>
---
 drivers/i2c/busses/i2c-cpm.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
index c1e1096..bb94c6d 100644
--- a/drivers/i2c/busses/i2c-cpm.c
+++ b/drivers/i2c/busses/i2c-cpm.c
@@ -338,6 +338,14 @@ static int cpm_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
 	tptr = 0;
 	rptr = 0;
 
+	/*
+	 * If there was a collision in the last i2c transaction,
+	 * Set I2COM_MASTER as it was cleared during collision.
+	 */
+	if (in_be16(&tbdf->cbd_sc) & BD_SC_CL) {
+		out_8(&cpm->i2c_reg->i2com, I2COM_MASTER);
+	}
+
 	while (tptr < num) {
 		pmsg = &msgs[tptr];
 		dev_dbg(&adap->dev, "R: %d T: %d\n", rptr, tptr);
-- 
1.7.9.5

                 reply	other threads:[~2012-11-25 22:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353882001-30744-1-git-send-email-sachin.surendran@gmail.com \
    --to=sachin.surendran@gmail.com \
    --cc=galak@kernel.crashing.org \
    --cc=jochen@scram.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sachin.surendran@alliedtelesis.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).