* [PATCH 1/4] powerpc/fsl: msi: sparse fixes
@ 2012-11-30 23:34 Kim Phillips
2012-11-30 23:35 ` [PATCH 2/4] powerpc/fsl: lbc: " Kim Phillips
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Kim Phillips @ 2012-11-30 23:34 UTC (permalink / raw)
To: linuxppc-dev
arch/powerpc/sysdev/fsl_msi.c:31:1: warning: symbol 'msi_head' was not declared. Should it be static?
arch/powerpc/sysdev/fsl_msi.c:138:40: warning: incorrect type in argument 1 (different base types)
arch/powerpc/sysdev/fsl_msi.c:138:40: expected restricted __be64 const [usertype] *p
arch/powerpc/sysdev/fsl_msi.c:138:40: got unsigned long long const [usertype] *[assigned] reg
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
arch/powerpc/sysdev/fsl_msi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
index 63c5f04..a57ef97 100644
--- a/arch/powerpc/sysdev/fsl_msi.c
+++ b/arch/powerpc/sysdev/fsl_msi.c
@@ -28,7 +28,7 @@
#include "fsl_msi.h"
#include "fsl_pci.h"
-LIST_HEAD(msi_head);
+static LIST_HEAD(msi_head);
struct fsl_msi_feature {
u32 fsl_pic_ip;
@@ -130,7 +130,7 @@ static void fsl_compose_msi_msg(struct pci_dev *pdev, int hwirq,
struct pci_controller *hose = pci_bus_to_host(pdev->bus);
u64 address; /* Physical address of the MSIIR */
int len;
- const u64 *reg;
+ const __be64 *reg;
/* If the msi-address-64 property exists, then use it */
reg = of_get_property(hose->dn, "msi-address-64", &len);
--
1.8.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] powerpc/fsl: lbc: sparse fixes
2012-11-30 23:34 [PATCH 1/4] powerpc/fsl: msi: sparse fixes Kim Phillips
@ 2012-11-30 23:35 ` Kim Phillips
2012-11-30 23:35 ` [PATCH 3/4] powerpc/fsl: ifc: " Kim Phillips
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2012-11-30 23:35 UTC (permalink / raw)
To: linuxppc-dev
arch/powerpc/sysdev/fsl_lbc.c:77:36: warning: incorrect type in initializer (different base types)
arch/powerpc/sysdev/fsl_lbc.c:77:36: expected restricted __be32 [usertype] br
arch/powerpc/sysdev/fsl_lbc.c:77:36: got unsigned int
arch/powerpc/sysdev/fsl_lbc.c:78:36: warning: incorrect type in initializer (different base types)
arch/powerpc/sysdev/fsl_lbc.c:78:36: expected restricted __be32 [usertype] or
arch/powerpc/sysdev/fsl_lbc.c:78:36: got unsigned int
arch/powerpc/sysdev/fsl_lbc.c:80:21: warning: restricted __be32 degrades to integer
arch/powerpc/sysdev/fsl_lbc.c:80:38: warning: restricted __be32 degrades to integer
arch/powerpc/sysdev/fsl_lbc.c:111:12: warning: incorrect type in assignment (different base types)
arch/powerpc/sysdev/fsl_lbc.c:111:12: expected restricted __be32 [usertype] br
arch/powerpc/sysdev/fsl_lbc.c:111:12: got unsigned int
arch/powerpc/sysdev/fsl_lbc.c:113:17: warning: restricted __be32 degrades to integer
arch/powerpc/sysdev/fsl_lbc.c:127:17: warning: restricted __be32 degrades to integer
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
arch/powerpc/sysdev/fsl_lbc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_lbc.c b/arch/powerpc/sysdev/fsl_lbc.c
index 483126d..2ee3967 100644
--- a/arch/powerpc/sysdev/fsl_lbc.c
+++ b/arch/powerpc/sysdev/fsl_lbc.c
@@ -74,8 +74,8 @@ int fsl_lbc_find(phys_addr_t addr_base)
lbc = fsl_lbc_ctrl_dev->regs;
for (i = 0; i < ARRAY_SIZE(lbc->bank); i++) {
- __be32 br = in_be32(&lbc->bank[i].br);
- __be32 or = in_be32(&lbc->bank[i].or);
+ u32 br = in_be32(&lbc->bank[i].br);
+ u32 or = in_be32(&lbc->bank[i].or);
if (br & BR_V && (br & or & BR_BA) == fsl_lbc_addr(addr_base))
return i;
@@ -97,7 +97,7 @@ EXPORT_SYMBOL(fsl_lbc_find);
int fsl_upm_find(phys_addr_t addr_base, struct fsl_upm *upm)
{
int bank;
- __be32 br;
+ u32 br;
struct fsl_lbc_regs __iomem *lbc;
bank = fsl_lbc_find(addr_base);
--
1.8.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] powerpc/fsl: ifc: sparse fixes
2012-11-30 23:34 [PATCH 1/4] powerpc/fsl: msi: sparse fixes Kim Phillips
2012-11-30 23:35 ` [PATCH 2/4] powerpc/fsl: lbc: " Kim Phillips
@ 2012-11-30 23:35 ` Kim Phillips
2012-11-30 23:35 ` [PATCH 4/4] powerpc/fsl: fsl_soc: " Kim Phillips
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2012-11-30 23:35 UTC (permalink / raw)
To: linuxppc-dev
arch/powerpc/sysdev/fsl_ifc.c:66:38: warning: incorrect type in initializer (different base types)
arch/powerpc/sysdev/fsl_ifc.c:66:38: expected restricted __be32 [usertype] cspr
arch/powerpc/sysdev/fsl_ifc.c:66:38: got unsigned int
arch/powerpc/sysdev/fsl_ifc.c:67:21: warning: restricted __be32 degrades to integer
arch/powerpc/sysdev/fsl_ifc.c:67:39: warning: restricted __be32 degrades to integer
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
arch/powerpc/sysdev/fsl_ifc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/fsl_ifc.c b/arch/powerpc/sysdev/fsl_ifc.c
index 097cc9d2..dc11413 100644
--- a/arch/powerpc/sysdev/fsl_ifc.c
+++ b/arch/powerpc/sysdev/fsl_ifc.c
@@ -63,7 +63,7 @@ int fsl_ifc_find(phys_addr_t addr_base)
return -ENODEV;
for (i = 0; i < ARRAY_SIZE(fsl_ifc_ctrl_dev->regs->cspr_cs); i++) {
- __be32 cspr = in_be32(&fsl_ifc_ctrl_dev->regs->cspr_cs[i].cspr);
+ u32 cspr = in_be32(&fsl_ifc_ctrl_dev->regs->cspr_cs[i].cspr);
if (cspr & CSPR_V && (cspr & CSPR_BA) ==
convert_ifc_address(addr_base))
return i;
--
1.8.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] powerpc/fsl: fsl_soc: sparse fixes
2012-11-30 23:34 [PATCH 1/4] powerpc/fsl: msi: sparse fixes Kim Phillips
2012-11-30 23:35 ` [PATCH 2/4] powerpc/fsl: lbc: " Kim Phillips
2012-11-30 23:35 ` [PATCH 3/4] powerpc/fsl: ifc: " Kim Phillips
@ 2012-11-30 23:35 ` Kim Phillips
2013-02-12 20:02 ` [PATCH 1/4] powerpc/fsl: msi: " Kumar Gala
2013-02-12 20:07 ` Kumar Gala
4 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2012-11-30 23:35 UTC (permalink / raw)
To: linuxppc-dev
arch/powerpc/sysdev/fsl_soc.c:70:67: warning: incorrect type in argument 2 (different base types)
arch/powerpc/sysdev/fsl_soc.c:70:67: expected restricted __be32 const [usertype] *addr
arch/powerpc/sysdev/fsl_soc.c:70:67: got unsigned int const [usertype] *
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
arch/powerpc/sysdev/fsl_soc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index 97118dc..228cf91 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -58,10 +58,10 @@ phys_addr_t get_immrbase(void)
if (soc) {
int size;
u32 naddr;
- const u32 *prop = of_get_property(soc, "#address-cells", &size);
+ const __be32 *prop = of_get_property(soc, "#address-cells", &size);
if (prop && size == 4)
- naddr = *prop;
+ naddr = be32_to_cpup(prop);
else
naddr = 2;
--
1.8.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] powerpc/fsl: msi: sparse fixes
2012-11-30 23:34 [PATCH 1/4] powerpc/fsl: msi: sparse fixes Kim Phillips
` (2 preceding siblings ...)
2012-11-30 23:35 ` [PATCH 4/4] powerpc/fsl: fsl_soc: " Kim Phillips
@ 2013-02-12 20:02 ` Kumar Gala
2013-02-12 20:07 ` Kumar Gala
4 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2013-02-12 20:02 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
On Nov 30, 2012, at 5:34 PM, Kim Phillips wrote:
> arch/powerpc/sysdev/fsl_msi.c:31:1: warning: symbol 'msi_head' was not =
declared. Should it be static?
> arch/powerpc/sysdev/fsl_msi.c:138:40: warning: incorrect type in =
argument 1 (different base types)
> arch/powerpc/sysdev/fsl_msi.c:138:40: expected restricted __be64 =
const [usertype] *p
> arch/powerpc/sysdev/fsl_msi.c:138:40: got unsigned long long const =
[usertype] *[assigned] reg
>=20
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/sysdev/fsl_msi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied 1-4 to next
- k=
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] powerpc/fsl: msi: sparse fixes
2012-11-30 23:34 [PATCH 1/4] powerpc/fsl: msi: sparse fixes Kim Phillips
` (3 preceding siblings ...)
2013-02-12 20:02 ` [PATCH 1/4] powerpc/fsl: msi: " Kumar Gala
@ 2013-02-12 20:07 ` Kumar Gala
4 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2013-02-12 20:07 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
On Nov 30, 2012, at 5:34 PM, Kim Phillips wrote:
> arch/powerpc/sysdev/fsl_msi.c:31:1: warning: symbol 'msi_head' was not =
declared. Should it be static?
> arch/powerpc/sysdev/fsl_msi.c:138:40: warning: incorrect type in =
argument 1 (different base types)
> arch/powerpc/sysdev/fsl_msi.c:138:40: expected restricted __be64 =
const [usertype] *p
> arch/powerpc/sysdev/fsl_msi.c:138:40: got unsigned long long const =
[usertype] *[assigned] reg
>=20
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/powerpc/sysdev/fsl_msi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied 1-4 to next
- k=
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-12 20:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-30 23:34 [PATCH 1/4] powerpc/fsl: msi: sparse fixes Kim Phillips
2012-11-30 23:35 ` [PATCH 2/4] powerpc/fsl: lbc: " Kim Phillips
2012-11-30 23:35 ` [PATCH 3/4] powerpc/fsl: ifc: " Kim Phillips
2012-11-30 23:35 ` [PATCH 4/4] powerpc/fsl: fsl_soc: " Kim Phillips
2013-02-12 20:02 ` [PATCH 1/4] powerpc/fsl: msi: " Kumar Gala
2013-02-12 20:07 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).