From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B3C292C00BE for ; Wed, 5 Dec 2012 18:20:37 +1100 (EST) Message-ID: <1354692031.2351.4.camel@pasglop> Subject: Re: [PATCH 1/3] powerpc: Relocate prom_init.c on 64bit From: Benjamin Herrenschmidt To: Anton Blanchard Date: Wed, 05 Dec 2012 18:20:31 +1100 In-Reply-To: <20121205110723.68839261@kryten> References: <20121127143903.4b5cab17@kryten> <1353993743.2179.28.camel@pasglop> <20121205110723.68839261@kryten> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org, amodra@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2012-12-05 at 11:07 +1100, Anton Blanchard wrote: > Hi Ben, > > > My only potential objection was that it might have been cleaner to > > actually build prom_init.c as a separate binary alltogether and piggy > > back it... > > Yeah, I went through a number of options before settling on this one. Heh, yeah, that what happens when nothing is fully satisfactory... .../... > Build prom_init.c 32 bit, tack it onto the end of the vmlinux and > add a trampoline at the start of the vmlinux. > > This means a vmlinux will be bootable and profiling tools will work > against it. Even so it feels gross to me. It does, might be less gross to have prom_init.c be .incbin'ed in vmlinux like the vdso is ... better than tacking it at the end. Still makes it annoying to debug crashes in prom_init itself. I'll review your patch when I get a chance as the "least bad" solution :-) Cheers, Ben.