From: Michael Ellerman <michael@ellerman.id.au>
To: Haren Myneni <haren@linux.vnet.ibm.com>
Cc: paulus@samba.org, anton@au1.ibm.com,
Michael Neuling <michael.neuling@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/6] powerpc: Macros for saving/restore PPR
Date: Tue, 11 Dec 2012 13:41:11 +1100 [thread overview]
Message-ID: <1355193671.8733.6.camel@concordia> (raw)
In-Reply-To: <50B41C27.4020905@linux.vnet.ibm.com>
On Mon, 2012-11-26 at 17:49 -0800, Haren Myneni wrote:
> On 11/22/2012 07:39 PM, Michael Neuling wrote:
> > Haren Myneni <haren@linux.vnet.ibm.com> wrote:
> >
> >> [PATCH 5/6] powerpc: Macros for saving/restore PPR
> >
> > Maybe we should change the names
> > HTM_MEDIUM_NO_PPR => HTM_MEDIUM_PPR_DISCARD and
> > HTM_MEDIUM_HAS_PPR => HTM_MEDIUM_PPR_SAVE
> > But now I'm heading into bike shedding territory... plus I think I
> > suggested the names you have currently, so I'm feeling a bit dumb now
> > :-)
>
> No problem, We can change these macro names if HTM_MEDIUM_PPR_DISCARD/
> HTM_MEDIUM_PPR_SAVE gives better description.
Yes, those names are better.
Even though they're macros they act as functions, so they should
preferably be named using a verb.
cheers
next prev parent reply other threads:[~2012-12-11 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 6:56 [PATCH 5/6] powerpc: Macros for saving/restore PPR Haren Myneni
2012-11-23 3:39 ` Michael Neuling
2012-11-27 1:49 ` Haren Myneni
2012-12-11 2:41 ` Michael Ellerman [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-07 7:50 Haren Myneni
2012-09-09 11:43 Haren Myneni
2012-09-10 4:24 ` Benjamin Herrenschmidt
2012-09-11 5:18 ` Haren Myneni
2012-09-11 5:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355193671.8733.6.camel@concordia \
--to=michael@ellerman.id.au \
--cc=anton@au1.ibm.com \
--cc=haren@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael.neuling@au1.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).