From: Peter Bergner <bergner@vnet.ibm.com>
To: Jimi Xenidis <jimix@pobox.com>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
Kumar Gala <kumar.gala@gmail.com>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH] powerpc: POWER7 optimised memcpy using VMX and enhanced prefetch
Date: Mon, 17 Dec 2012 18:26:13 -0600 [thread overview]
Message-ID: <1355790373.5180.26.camel@otta> (raw)
In-Reply-To: <20121217223333.6cb00476@kryten>
On Mon, 2012-12-17 at 22:33 +1100, Anton Blanchard wrote:
> Hi Jimi,
>
> > I know this is a little late, but shouldn't these power7 specific
> > thingies be in "obj-$(CONFIG_PPC_BOOK3S_64)". The reason I ask is
> > that my compiler pukes on "dcbtst" and as I deal with that I wanted
> > to point this out.
>
> I guess we could do that. It's a bit strange your assembler is
> complaining about the dcbtst instructions since we wrap them with
> power4:
>
> .machine push
> .machine "power4"
> dcbt r0,r4,0b01000
> dcbt r0,r7,0b01010
> dcbtst r0,r9,0b01000
> dcbtst r0,r10,0b01010
> eieio
> dcbt r0,r8,0b01010 /* GO */
> .machine pop
Jimi, are you using an "old" binutils from before my patch that
changed the operand order for these types of instructions?
http://sourceware.org/ml/binutils/2009-02/msg00044.html
Peter
next prev parent reply other threads:[~2012-12-18 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 6:22 [PATCH] powerpc: POWER7 optimised memcpy using VMX and enhanced prefetch Anton Blanchard
2012-12-07 23:20 ` Jimi Xenidis
2012-12-17 11:33 ` Anton Blanchard
2012-12-18 0:26 ` Peter Bergner [this message]
2012-12-18 13:28 ` Jimi Xenidis
2012-12-18 14:14 ` David Laight
2012-12-18 16:31 ` Peter Bergner
2013-01-09 22:19 ` Jimi Xenidis
2013-01-09 23:06 ` Peter Bergner
2012-12-18 13:21 ` Jimi Xenidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355790373.5180.26.camel@otta \
--to=bergner@vnet.ibm.com \
--cc=anton@samba.org \
--cc=jimix@pobox.com \
--cc=kumar.gala@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).