* [PATCH] Added device tree binding for TDM and TDM phy
@ 2013-01-02 13:25 Sandeep Singh
2013-01-09 7:10 ` Singh Sandeep-B37400
0 siblings, 1 reply; 6+ messages in thread
From: Sandeep Singh @ 2013-01-02 13:25 UTC (permalink / raw)
To: devicetree-discuss, linuxppc-dev; +Cc: Sandeep Singh, Poonam Aggrwal
This controller is available on many Freescale SOCs like MPC8315, P1020, P1010
and P1022
Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
.../devicetree/bindings/powerpc/fsl/fsl-tdm.txt | 63 ++++++++++++++++++++
.../devicetree/bindings/powerpc/fsl/tdm-phy.txt | 38 ++++++++++++
2 files changed, 101 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
new file mode 100644
index 0000000..ceb2ef1
--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
@@ -0,0 +1,63 @@
+TDM Device Tree Binding
+
+NOTE: The bindings described in this document are preliminary
+and subject to change.
+
+TDM (Time Division Multiplexing)
+
+Description:
+
+The TDM is full duplex serial port designed to allow various devices including
+digital signal processors (DSPs) to communicate with a variety of serial devices
+including industry standard framers, codecs, other DSPs and microprocessors.
+
+The below properties describe the device tree bindings for Freescale TDM
+controller. This TDM controller is available on various Freescale Processors
+like MPC8315, P1020, P1022 and P1010.
+
+Required properties:
+
+- compatible
+ Value type: <string>
+ Definition: Should contain "fsl,tdm1.0".
+
+- reg
+ Definition: A standard property. The first reg specifier describes the TDM
+ registers, and the second describes the TDM DMAC registers.
+
+- tdm_tx_clk
+ Value type: <u32 or u64>
+ Definition: This specifies the value of transmit clock. It should not
+ exceed 50Mhz.
+
+- tdm_rx_clk
+ Value type: <u32 or u64>
+ Definition: This specifies the value of receive clock. Its value could be
+ zero, in which case tdm will operate in shared mode. Its value should not
+ exceed 50Mhz.
+
+- interrupts
+ Definition: Two interrupt specifiers. The first is TDM error, and the
+ second is TDM DMAC.
+
+- phy-handle
+ Value type: <phandle>
+ Definition: Phandle of the line controller node or framer node eg. SLIC,
+ E1/T1 etc. (Refer Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt)
+
+- fsl,max-time-slots
+ Value type: <u32>
+ Definition: Maximum number of 8-bit time slots in one TDM frame. This is
+ the maximum number which TDM hardware supports.
+
+Example:
+
+ tdm@16000 {
+ compatible = "fsl,tdm1.0";
+ reg = <0x16000 0x200 0x2c000 0x2000>;
+ tdm_tx_clk = <2048000>;
+ tdm_rx_clk = <0>;
+ interrupts = <16 8 62 8>;
+ phy-handle = <&tdm-phy>;
+ fsl,max-time-slots = <128>;
+ };
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
new file mode 100644
index 0000000..2563934
--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
@@ -0,0 +1,38 @@
+TDM PHY Device Tree Binding
+
+NOTE: The bindings described in this document are preliminary
+and subject to change.
+
+Description:
+TDM PHY is the terminal interface of TDM subsystem. It is typically a line
+control device like E1/T1 framer or SLIC. A TDM device can have multiple TDM
+PHYs.
+
+Required properties:
+
+- compatible
+ Value type: <string>
+ Definition: Should contain generic compatibility like "tdm-phy-slic" or
+ "tdm-phy-e1" or "tdm-phy-t1".
+
+- max-num-ports
+ Value type: <u32>
+ Definition: Defines the maximum number of ports supported by the SLIC
+ device. Only required if the device is SLIC. For E1/T1 devices the number
+ of ports are predefined i.e. (24 in case of T1 and 32 in case of E1).
+
+Apart from the above, there may be other properties required because of the
+bus/interface this device is connected on. It could be SPI/local bus, etc.
+
+Example:
+
+ tdm-phy@0 {
+ compatible = "zarlink,le88266","tdm-phy-slic";
+ reg = <0>;
+ max-num-ports = <4>;
+ spi-max-frequency = <8000000>;
+ };
+
+In the above example properties "reg" and "spi-max-frequency" are SPI specific
+as the SLIC device is connected on SPI interface. These properties might vary
+depending on the specific interface the device is using.
--
1.7.6.GIT
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] Added device tree binding for TDM and TDM phy
2013-01-02 13:25 [PATCH] Added device tree binding for TDM and TDM phy Sandeep Singh
@ 2013-01-09 7:10 ` Singh Sandeep-B37400
2013-01-10 0:07 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Singh Sandeep-B37400 @ 2013-01-09 7:10 UTC (permalink / raw)
To: devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org
Cc: Aggrwal Poonam-B10812
A gentle reminder.
Any comments are appreciated.
Regards,
Sandeep
> -----Original Message-----
> From: Singh Sandeep-B37400
> Sent: Wednesday, January 02, 2013 6:55 PM
> To: devicetree-discuss@lists.ozlabs.org; linuxppc-dev@ozlabs.org
> Cc: Singh Sandeep-B37400; Aggrwal Poonam-B10812
> Subject: [PATCH] Added device tree binding for TDM and TDM phy
>=20
> This controller is available on many Freescale SOCs like MPC8315, P1020,
> P1010 and P1022
>=20
> Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> ---
> .../devicetree/bindings/powerpc/fsl/fsl-tdm.txt | 63
> ++++++++++++++++++++
> .../devicetree/bindings/powerpc/fsl/tdm-phy.txt | 38 ++++++++++++
> 2 files changed, 101 insertions(+), 0 deletions(-) create mode 100644
> Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/tdm-
> phy.txt
>=20
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> new file mode 100644
> index 0000000..ceb2ef1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> @@ -0,0 +1,63 @@
> +TDM Device Tree Binding
> +
> +NOTE: The bindings described in this document are preliminary and
> +subject to change.
> +
> +TDM (Time Division Multiplexing)
> +
> +Description:
> +
> +The TDM is full duplex serial port designed to allow various devices
> +including digital signal processors (DSPs) to communicate with a
> +variety of serial devices including industry standard framers, codecs,
> other DSPs and microprocessors.
> +
> +The below properties describe the device tree bindings for Freescale
> +TDM controller. This TDM controller is available on various Freescale
> +Processors like MPC8315, P1020, P1022 and P1010.
> +
> +Required properties:
> +
> +- compatible
> + Value type: <string>
> + Definition: Should contain "fsl,tdm1.0".
> +
> +- reg
> + Definition: A standard property. The first reg specifier describes
> the TDM
> + registers, and the second describes the TDM DMAC registers.
> +
> +- tdm_tx_clk
> + Value type: <u32 or u64>
> + Definition: This specifies the value of transmit clock. It should
> not
> + exceed 50Mhz.
> +
> +- tdm_rx_clk
> + Value type: <u32 or u64>
> + Definition: This specifies the value of receive clock. Its value
> could be
> + zero, in which case tdm will operate in shared mode. Its value
> should not
> + exceed 50Mhz.
> +
> +- interrupts
> + Definition: Two interrupt specifiers. The first is TDM error, and
> the
> + second is TDM DMAC.
> +
> +- phy-handle
> + Value type: <phandle>
> + Definition: Phandle of the line controller node or framer node eg.
> SLIC,
> + E1/T1 etc. (Refer
> +Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt)
> +
> +- fsl,max-time-slots
> + Value type: <u32>
> + Definition: Maximum number of 8-bit time slots in one TDM frame.
> This is
> + the maximum number which TDM hardware supports.
> +
> +Example:
> +
> + tdm@16000 {
> + compatible =3D "fsl,tdm1.0";
> + reg =3D <0x16000 0x200 0x2c000 0x2000>;
> + tdm_tx_clk =3D <2048000>;
> + tdm_rx_clk =3D <0>;
> + interrupts =3D <16 8 62 8>;
> + phy-handle =3D <&tdm-phy>;
> + fsl,max-time-slots =3D <128>;
> + };
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> new file mode 100644
> index 0000000..2563934
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> @@ -0,0 +1,38 @@
> +TDM PHY Device Tree Binding
> +
> +NOTE: The bindings described in this document are preliminary and
> +subject to change.
> +
> +Description:
> +TDM PHY is the terminal interface of TDM subsystem. It is typically a
> +line control device like E1/T1 framer or SLIC. A TDM device can have
> +multiple TDM PHYs.
> +
> +Required properties:
> +
> +- compatible
> + Value type: <string>
> + Definition: Should contain generic compatibility like "tdm-phy-slic"
> or
> + "tdm-phy-e1" or "tdm-phy-t1".
> +
> +- max-num-ports
> + Value type: <u32>
> + Definition: Defines the maximum number of ports supported by the
> SLIC
> + device. Only required if the device is SLIC. For E1/T1 devices the
> number
> + of ports are predefined i.e. (24 in case of T1 and 32 in case of
> E1).
> +
> +Apart from the above, there may be other properties required because of
> +the bus/interface this device is connected on. It could be SPI/local
> bus, etc.
> +
> +Example:
> +
> + tdm-phy@0 {
> + compatible =3D "zarlink,le88266","tdm-phy-slic";
> + reg =3D <0>;
> + max-num-ports =3D <4>;
> + spi-max-frequency =3D <8000000>;
> + };
> +
> +In the above example properties "reg" and "spi-max-frequency" are SPI
> +specific as the SLIC device is connected on SPI interface. These
> +properties might vary depending on the specific interface the device is
> using.
> --
> 1.7.6.GIT
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added device tree binding for TDM and TDM phy
2013-01-09 7:10 ` Singh Sandeep-B37400
@ 2013-01-10 0:07 ` Scott Wood
2013-01-10 9:24 ` Singh Sandeep-B37400
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2013-01-10 0:07 UTC (permalink / raw)
To: Singh Sandeep-B37400
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org,
Aggrwal Poonam-B10812
On 01/09/2013 01:10:24 AM, Singh Sandeep-B37400 wrote:
> A gentle reminder.
> Any comments are appreciated.
>=20
> Regards,
> Sandeep
>=20
> > -----Original Message-----
> > From: Singh Sandeep-B37400
> > Sent: Wednesday, January 02, 2013 6:55 PM
> > To: devicetree-discuss@lists.ozlabs.org; linuxppc-dev@ozlabs.org
> > Cc: Singh Sandeep-B37400; Aggrwal Poonam-B10812
> > Subject: [PATCH] Added device tree binding for TDM and TDM phy
> >
> > This controller is available on many Freescale SOCs like MPC8315, =20
> P1020,
> > P1010 and P1022
> >
> > Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
> > Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> > ---
> > .../devicetree/bindings/powerpc/fsl/fsl-tdm.txt | 63
> > ++++++++++++++++++++
> > .../devicetree/bindings/powerpc/fsl/tdm-phy.txt | 38 =20
> ++++++++++++
> > 2 files changed, 101 insertions(+), 0 deletions(-) create mode =20
> 100644
> > Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > create mode 100644 =20
> Documentation/devicetree/bindings/powerpc/fsl/tdm-
> > phy.txt
> >
> > diff --git =20
> a/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > new file mode 100644
> > index 0000000..ceb2ef1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > @@ -0,0 +1,63 @@
> > +TDM Device Tree Binding
> > +
> > +NOTE: The bindings described in this document are preliminary and
> > +subject to change.
> > +
> > +TDM (Time Division Multiplexing)
> > +
> > +Description:
> > +
> > +The TDM is full duplex serial port designed to allow various =20
> devices
> > +including digital signal processors (DSPs) to communicate with a
> > +variety of serial devices including industry standard framers, =20
> codecs,
> > other DSPs and microprocessors.
> > +
> > +The below properties describe the device tree bindings for =20
> Freescale
> > +TDM controller. This TDM controller is available on various =20
> Freescale
> > +Processors like MPC8315, P1020, P1022 and P1010.
> > +
> > +Required properties:
> > +
> > +- compatible
> > + Value type: <string>
> > + Definition: Should contain "fsl,tdm1.0".
> > +
> > +- reg
> > + Definition: A standard property. The first reg specifier =20
> describes
> > the TDM
> > + registers, and the second describes the TDM DMAC registers.
> > +
> > +- tdm_tx_clk
> > + Value type: <u32 or u64>
> > + Definition: This specifies the value of transmit clock. It =20
> should
> > not
> > + exceed 50Mhz.
> > +
> > +- tdm_rx_clk
> > + Value type: <u32 or u64>
> > + Definition: This specifies the value of receive clock. Its =20
> value
> > could be
> > + zero, in which case tdm will operate in shared mode. Its value
> > should not
> > + exceed 50Mhz.
Please don't use underscores in property names, and use the vendor =20
prefix: "fsl,tdm-tx-clk" and "fsl,tdm-rx-clk".
> > diff --git =20
> a/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> > new file mode 100644
> > index 0000000..2563934
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> > @@ -0,0 +1,38 @@
> > +TDM PHY Device Tree Binding
> > +
> > +NOTE: The bindings described in this document are preliminary and
> > +subject to change.
> > +
> > +Description:
> > +TDM PHY is the terminal interface of TDM subsystem. It is =20
> typically a
> > +line control device like E1/T1 framer or SLIC. A TDM device can =20
> have
> > +multiple TDM PHYs.
> > +
> > +Required properties:
> > +
> > +- compatible
> > + Value type: <string>
> > + Definition: Should contain generic compatibility like =20
> "tdm-phy-slic"
> > or
> > + "tdm-phy-e1" or "tdm-phy-t1".
Does this "generic" string (plus the other properties) tell you all you =20
need to know about the device? If there are other possible "generic" =20
compatibles, they should be listed or else different people will make =20
up different strings for the same thing.
-Scott=
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Added device tree binding for TDM and TDM phy
2013-01-10 0:07 ` Scott Wood
@ 2013-01-10 9:24 ` Singh Sandeep-B37400
2013-01-10 19:48 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Singh Sandeep-B37400 @ 2013-01-10 9:24 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org,
Aggrwal Poonam-B10812
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, January 10, 2013 5:37 AM
> To: Singh Sandeep-B37400
> Cc: devicetree-discuss@lists.ozlabs.org; linuxppc-dev@ozlabs.org; Aggrwal
> Poonam-B10812
> Subject: Re: [PATCH] Added device tree binding for TDM and TDM phy
>=20
> On 01/09/2013 01:10:24 AM, Singh Sandeep-B37400 wrote:
> > A gentle reminder.
> > Any comments are appreciated.
> >
> > Regards,
> > Sandeep
> >
> > > -----Original Message-----
> > > From: Singh Sandeep-B37400
> > > Sent: Wednesday, January 02, 2013 6:55 PM
> > > To: devicetree-discuss@lists.ozlabs.org; linuxppc-dev@ozlabs.org
> > > Cc: Singh Sandeep-B37400; Aggrwal Poonam-B10812
> > > Subject: [PATCH] Added device tree binding for TDM and TDM phy
> > >
> > > This controller is available on many Freescale SOCs like MPC8315,
> > P1020,
> > > P1010 and P1022
> > >
> > > Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
> > > Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> > > ---
> > > .../devicetree/bindings/powerpc/fsl/fsl-tdm.txt | 63
> > > ++++++++++++++++++++
> > > .../devicetree/bindings/powerpc/fsl/tdm-phy.txt | 38
> > ++++++++++++
> > > 2 files changed, 101 insertions(+), 0 deletions(-) create mode
> > 100644
> > > Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > > create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/tdm-
> > > phy.txt
> > >
> > > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > > new file mode 100644
> > > index 0000000..ceb2ef1
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fsl-tdm.txt
> > > @@ -0,0 +1,63 @@
> > > +TDM Device Tree Binding
> > > +
> > > +NOTE: The bindings described in this document are preliminary and
> > > +subject to change.
> > > +
> > > +TDM (Time Division Multiplexing)
> > > +
> > > +Description:
> > > +
> > > +The TDM is full duplex serial port designed to allow various
> > devices
> > > +including digital signal processors (DSPs) to communicate with a
> > > +variety of serial devices including industry standard framers,
> > codecs,
> > > other DSPs and microprocessors.
> > > +
> > > +The below properties describe the device tree bindings for
> > Freescale
> > > +TDM controller. This TDM controller is available on various
> > Freescale
> > > +Processors like MPC8315, P1020, P1022 and P1010.
> > > +
> > > +Required properties:
> > > +
> > > +- compatible
> > > + Value type: <string>
> > > + Definition: Should contain "fsl,tdm1.0".
> > > +
> > > +- reg
> > > + Definition: A standard property. The first reg specifier
> > describes
> > > the TDM
> > > + registers, and the second describes the TDM DMAC registers.
> > > +
> > > +- tdm_tx_clk
> > > + Value type: <u32 or u64>
> > > + Definition: This specifies the value of transmit clock. It
> > should
> > > not
> > > + exceed 50Mhz.
> > > +
> > > +- tdm_rx_clk
> > > + Value type: <u32 or u64>
> > > + Definition: This specifies the value of receive clock. Its
> > value
> > > could be
> > > + zero, in which case tdm will operate in shared mode. Its value
> > > should not
> > > + exceed 50Mhz.
>=20
> Please don't use underscores in property names, and use the vendor
> prefix: "fsl,tdm-tx-clk" and "fsl,tdm-rx-clk".
Ok.
>=20
> > > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> > > new file mode 100644
> > > index 0000000..2563934
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/tdm-phy.txt
> > > @@ -0,0 +1,38 @@
> > > +TDM PHY Device Tree Binding
> > > +
> > > +NOTE: The bindings described in this document are preliminary and
> > > +subject to change.
> > > +
> > > +Description:
> > > +TDM PHY is the terminal interface of TDM subsystem. It is
> > typically a
> > > +line control device like E1/T1 framer or SLIC. A TDM device can
> > have
> > > +multiple TDM PHYs.
> > > +
> > > +Required properties:
> > > +
> > > +- compatible
> > > + Value type: <string>
> > > + Definition: Should contain generic compatibility like
> > "tdm-phy-slic"
> > > or
> > > + "tdm-phy-e1" or "tdm-phy-t1".
>=20
> Does this "generic" string (plus the other properties) tell you all you
> need to know about the device? If there are other possible "generic"
> compatibles, they should be listed or else different people will make up
> different strings for the same thing.
This property will describe the type of device, and will help TDM framework
to know if it is E1/T1/SLIC device. Further details can be extracted from o=
ther
compatible strings.
There are only three generic compatibles field types, which are already men=
tioned
in definition. Do I need to make this thing more clear.
>=20
> -Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added device tree binding for TDM and TDM phy
2013-01-10 9:24 ` Singh Sandeep-B37400
@ 2013-01-10 19:48 ` Scott Wood
2013-01-11 6:01 ` Singh Sandeep-B37400
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2013-01-10 19:48 UTC (permalink / raw)
To: Singh Sandeep-B37400
Cc: Wood Scott-B07421, devicetree-discuss@lists.ozlabs.org,
Aggrwal Poonam-B10812, linuxppc-dev@ozlabs.org
On 01/10/2013 03:24:21 AM, Singh Sandeep-B37400 wrote:
> > > > +- compatible
> > > > + Value type: <string>
> > > > + Definition: Should contain generic compatibility like
> > > "tdm-phy-slic"
> > > > or
> > > > + "tdm-phy-e1" or "tdm-phy-t1".
> >
> > Does this "generic" string (plus the other properties) tell you all =20
> you
> > need to know about the device? If there are other possible =20
> "generic"
> > compatibles, they should be listed or else different people will =20
> make up
> > different strings for the same thing.
>=20
> This property will describe the type of device, and will help TDM =20
> framework
> to know if it is E1/T1/SLIC device. Further details can be extracted =20
> from other
> compatible strings.
> There are only three generic compatibles field types, which are =20
> already mentioned
> in definition. Do I need to make this thing more clear.
The word "like" suggests that there are other possibilites. It would =20
be clearer as:
Definition: One of "tdm-phy-slic", "tdm-phy-e1", or "tdm-phy-t1".
-Scott=
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Added device tree binding for TDM and TDM phy
2013-01-10 19:48 ` Scott Wood
@ 2013-01-11 6:01 ` Singh Sandeep-B37400
0 siblings, 0 replies; 6+ messages in thread
From: Singh Sandeep-B37400 @ 2013-01-11 6:01 UTC (permalink / raw)
To: Wood Scott-B07421
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org,
Aggrwal Poonam-B10812
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, January 11, 2013 1:19 AM
> To: Singh Sandeep-B37400
> Cc: Wood Scott-B07421; devicetree-discuss@lists.ozlabs.org; linuxppc-
> dev@ozlabs.org; Aggrwal Poonam-B10812
> Subject: Re: [PATCH] Added device tree binding for TDM and TDM phy
>=20
> On 01/10/2013 03:24:21 AM, Singh Sandeep-B37400 wrote:
> > > > > +- compatible
> > > > > + Value type: <string>
> > > > > + Definition: Should contain generic compatibility like
> > > > "tdm-phy-slic"
> > > > > or
> > > > > + "tdm-phy-e1" or "tdm-phy-t1".
> > >
> > > Does this "generic" string (plus the other properties) tell you all
> > you
> > > need to know about the device? If there are other possible
> > "generic"
> > > compatibles, they should be listed or else different people will
> > make up
> > > different strings for the same thing.
> >
> > This property will describe the type of device, and will help TDM
> > framework to know if it is E1/T1/SLIC device. Further details can be
> > extracted from other compatible strings.
> > There are only three generic compatibles field types, which are
> > already mentioned in definition. Do I need to make this thing more
> > clear.
>=20
> The word "like" suggests that there are other possibilites. It would be
> clearer as:
>=20
> Definition: One of "tdm-phy-slic", "tdm-phy-e1", or "tdm-phy-t1".
>=20
> -Scott
Ok, thanks for your comments.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-11 6:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-02 13:25 [PATCH] Added device tree binding for TDM and TDM phy Sandeep Singh
2013-01-09 7:10 ` Singh Sandeep-B37400
2013-01-10 0:07 ` Scott Wood
2013-01-10 9:24 ` Singh Sandeep-B37400
2013-01-10 19:48 ` Scott Wood
2013-01-11 6:01 ` Singh Sandeep-B37400
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).