* [PATCH] powerpc/mm: eliminate unneeded for_each_memblock
@ 2013-01-04 18:06 Cody P Schafer
2013-01-07 16:42 ` Kumar Gala
0 siblings, 1 reply; 3+ messages in thread
From: Cody P Schafer @ 2013-01-04 18:06 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Cody P Schafer, LKML, Paul Mackerras
The only persistent change made by this loop is calling
memblock_set_node() once for each memblock, which is not useful (and has
no effect) as memblock_set_node() is not called with any
memblock-specific parameters.
Subsistute a single memblock_set_node().
---
arch/powerpc/mm/mem.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 0dba506..50370bb 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -195,13 +195,8 @@ void __init do_init_bootmem(void)
min_low_pfn = MEMORY_START >> PAGE_SHIFT;
boot_mapsize = init_bootmem_node(NODE_DATA(0), start >> PAGE_SHIFT, min_low_pfn, max_low_pfn);
- /* Add active regions with valid PFNs */
- for_each_memblock(memory, reg) {
- unsigned long start_pfn, end_pfn;
- start_pfn = memblock_region_memory_base_pfn(reg);
- end_pfn = memblock_region_memory_end_pfn(reg);
- memblock_set_node(0, (phys_addr_t)ULLONG_MAX, 0);
- }
+ /* Place all memblock_regions in the same node and merge contiguous memblock_regions */
+ memblock_set_node(0, (phys_addr_t)ULLONG_MAX, 0);
/* Add all physical memory to the bootmem map, mark each area
* present.
--
1.8.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/mm: eliminate unneeded for_each_memblock
2013-01-04 18:06 [PATCH] powerpc/mm: eliminate unneeded for_each_memblock Cody P Schafer
@ 2013-01-07 16:42 ` Kumar Gala
2013-01-09 22:40 ` [PATCH v2] " Cody P Schafer
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2013-01-07 16:42 UTC (permalink / raw)
To: Cody P Schafer; +Cc: linuxppc-dev, LKML, Paul Mackerras
On Jan 4, 2013, at 12:06 PM, Cody P Schafer wrote:
> The only persistent change made by this loop is calling
> memblock_set_node() once for each memblock, which is not useful (and has
> no effect) as memblock_set_node() is not called with any
> memblock-specific parameters.
>
> Subsistute a single memblock_set_node().
> ---
> arch/powerpc/mm/mem.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Missing a signed-off-by
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] powerpc/mm: eliminate unneeded for_each_memblock
2013-01-07 16:42 ` Kumar Gala
@ 2013-01-09 22:40 ` Cody P Schafer
0 siblings, 0 replies; 3+ messages in thread
From: Cody P Schafer @ 2013-01-09 22:40 UTC (permalink / raw)
To: Linux PPC, galak; +Cc: Cody P Schafer, Paul Mackerras, LKML
The only persistent change made by this loop is calling
memblock_set_node() once for each memblock, which is not useful (and has
no effect) as memblock_set_node() is not called with any
memblock-specific parameters.
Subsistute a single memblock_set_node().
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
---
Now with a signoff & wrapped comment line.
arch/powerpc/mm/mem.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 0dba506..40df7c8 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -195,13 +195,10 @@ void __init do_init_bootmem(void)
min_low_pfn = MEMORY_START >> PAGE_SHIFT;
boot_mapsize = init_bootmem_node(NODE_DATA(0), start >> PAGE_SHIFT, min_low_pfn, max_low_pfn);
- /* Add active regions with valid PFNs */
- for_each_memblock(memory, reg) {
- unsigned long start_pfn, end_pfn;
- start_pfn = memblock_region_memory_base_pfn(reg);
- end_pfn = memblock_region_memory_end_pfn(reg);
- memblock_set_node(0, (phys_addr_t)ULLONG_MAX, 0);
- }
+ /* Place all memblock_regions in the same node and merge contiguous
+ * memblock_regions
+ */
+ memblock_set_node(0, (phys_addr_t)ULLONG_MAX, 0);
/* Add all physical memory to the bootmem map, mark each area
* present.
--
1.8.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-09 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-04 18:06 [PATCH] powerpc/mm: eliminate unneeded for_each_memblock Cody P Schafer
2013-01-07 16:42 ` Kumar Gala
2013-01-09 22:40 ` [PATCH v2] " Cody P Schafer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).