From: Scott Wood <scottwood@freescale.com>
To: Singh Sandeep-B37400 <B37400@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Aggrwal Poonam-B10812 <B10812@freescale.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] Added device tree binding for TDM and TDM phy
Date: Thu, 10 Jan 2013 13:48:38 -0600 [thread overview]
Message-ID: <1357847318.27576.9@snotra> (raw)
In-Reply-To: <3F1D9DCAAB49B94D88DBE05911FA4E6E69E4F0@039-SN1MPN1-005.039d.mgd.msft.net> (from B37400@freescale.com on Thu Jan 10 03:24:21 2013)
On 01/10/2013 03:24:21 AM, Singh Sandeep-B37400 wrote:
> > > > +- compatible
> > > > + Value type: <string>
> > > > + Definition: Should contain generic compatibility like
> > > "tdm-phy-slic"
> > > > or
> > > > + "tdm-phy-e1" or "tdm-phy-t1".
> >
> > Does this "generic" string (plus the other properties) tell you all =20
> you
> > need to know about the device? If there are other possible =20
> "generic"
> > compatibles, they should be listed or else different people will =20
> make up
> > different strings for the same thing.
>=20
> This property will describe the type of device, and will help TDM =20
> framework
> to know if it is E1/T1/SLIC device. Further details can be extracted =20
> from other
> compatible strings.
> There are only three generic compatibles field types, which are =20
> already mentioned
> in definition. Do I need to make this thing more clear.
The word "like" suggests that there are other possibilites. It would =20
be clearer as:
Definition: One of "tdm-phy-slic", "tdm-phy-e1", or "tdm-phy-t1".
-Scott=
next prev parent reply other threads:[~2013-01-10 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 13:25 [PATCH] Added device tree binding for TDM and TDM phy Sandeep Singh
2013-01-09 7:10 ` Singh Sandeep-B37400
2013-01-10 0:07 ` Scott Wood
2013-01-10 9:24 ` Singh Sandeep-B37400
2013-01-10 19:48 ` Scott Wood [this message]
2013-01-11 6:01 ` Singh Sandeep-B37400
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357847318.27576.9@snotra \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B10812@freescale.com \
--cc=B37400@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).