From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Michael Neuling <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: added DSCR support to ptrace
Date: Wed, 16 Jan 2013 05:17:15 +1100 [thread overview]
Message-ID: <1358273835.2782.5.camel@pasglop> (raw)
In-Reply-To: <1357885749-14042-1-git-send-email-aik@ozlabs.ru>
On Fri, 2013-01-11 at 17:29 +1100, Alexey Kardashevskiy wrote:
> +static unsigned long get_user_dscr(struct task_struct *task)
> +{
> + return -EIO;
> +}
> +
Does it make sense to return an error here ? ptrace_get_reg() doesn't
seem to have provisions for returning errors, it just return register
values, there's no way to differenciate an error code from a register
value as far as I can tell...
I'll apply your patch anyway because this is an existing problem with
that function (it already returns -EIO in other circumstances), but I
would like if you could submit a followup patch that changes it to
return the register by value and return a real error code, which can be
then handled properly in the two call sites (ptrace.c and ptrace32.c).
Cheers,
Ben.
next prev parent reply other threads:[~2013-01-15 18:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 6:29 [PATCH] powerpc: added DSCR support to ptrace Alexey Kardashevskiy
2013-01-15 18:17 ` Benjamin Herrenschmidt [this message]
2013-02-15 3:44 ` [PATCH] powerpc: fixing ptrace_get_reg to return an error Alexey Kardashevskiy
2013-04-10 5:00 ` Michael Neuling
-- strict thread matches above, loose matches on Subject: below --
2013-01-11 4:18 [PATCH] powerpc: added DSCR support to ptrace Alexey Kardashevskiy
2012-12-13 5:34 Alexey Kardashevskiy
2012-12-13 3:50 Alexey Kardashevskiy
2012-10-15 6:18 Alexey Kardashevskiy
2012-11-20 1:18 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358273835.2782.5.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).