linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Linux USB Mailing List <linux-usb@vger.kernel.org>
Cc: kgene.kim@samsung.com, eric.y.miao@gmail.com,
	kuninori.morimoto.gx@renesas.com,
	alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org,
	yoshihiro.shimoda.uh@renesas.com, nicolas.ferre@atmel.com,
	linux-geode@lists.infradead.org, haojian.zhuang@gmail.com,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	linux-samsung-soc@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
	ben-linux@fluff.org, dahlmann.thomas@arcor.de,
	linux@arm.linux.org.uk, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 03/32] usb: musb: gadget: let udc-core manage gadget-dev
Date: Thu, 24 Jan 2013 17:45:41 +0200	[thread overview]
Message-ID: <1359042370-4358-4-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1359042370-4358-1-git-send-email-balbi@ti.com>

By simply setting a flag, we can delete a little
boilerplate code.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/musb/musb_gadget.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index 8767874..1c4a8e8 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1871,12 +1871,11 @@ int musb_gadget_setup(struct musb *musb)
 	musb->g.speed = USB_SPEED_UNKNOWN;
 
 	/* this "gadget" abstracts/virtualizes the controller */
-	dev_set_name(&musb->g.dev, "gadget");
 	musb->g.dev.parent = musb->controller;
 	musb->g.dev.dma_mask = musb->controller->dma_mask;
 	musb->g.dev.release = musb_gadget_release;
 	musb->g.name = musb_driver_name;
-
+	musb->g.register_my_device = true;
 	musb->g.is_otg = 1;
 
 	musb_g_init_endpoints(musb);
@@ -1884,11 +1883,6 @@ int musb_gadget_setup(struct musb *musb)
 	musb->is_active = 0;
 	musb_platform_try_idle(musb, 0);
 
-	status = device_register(&musb->g.dev);
-	if (status != 0) {
-		put_device(&musb->g.dev);
-		return status;
-	}
 	status = usb_add_gadget_udc(musb->controller, &musb->g);
 	if (status)
 		goto err;
@@ -1903,8 +1897,6 @@ err:
 void musb_gadget_cleanup(struct musb *musb)
 {
 	usb_del_gadget_udc(&musb->g);
-	if (musb->g.dev.parent)
-		device_unregister(&musb->g.dev);
 }
 
 /*
-- 
1.8.1.rc1.5.g7e0651a

  parent reply	other threads:[~2013-01-24 15:46 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24 15:45 [RFC/PATCH 00/32] usb: refactor gadget->dev registration Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 01/32] usb: gadget: udc-core: allow udc class register gadget device Felipe Balbi
2013-01-24 18:57   ` Tomasz Figa
2013-01-24 15:45 ` [RFC/PATCH 02/32] usb: dwc3: gadget: let udc-core manage gadget->dev Felipe Balbi
2013-01-24 15:45 ` Felipe Balbi [this message]
2013-01-24 15:45 ` [RFC/PATCH 04/32] usb: gadget: omap_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 05/32] usb: gadget: amd5536udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 06/32] usb: gadget: at91_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 07/32] usb: gadget: atmel_usba_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 08/32] usb: gadget: bcm63xx_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 09/32] usb: gadget: dummy_hcd: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 10/32] usb: gadget: fsl_qe_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 11/32] usb: gadget: fsl_udc_core: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 12/32] usb: gadget: fusb300_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 13/32] usb: gadget: goku_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 14/32] usb: gadget: imx_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 15/32] usb: gadget: lpc32xx_udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 16/32] usb: gadget: m66592-udc: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 17/32] usb: gadget: mv_u3d_core: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 18/32] usb: gadget: mv_u3d_core: fix a compile warning Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 19/32] usb: gadget: mv_udc_core: let udc-core manage gadget->dev Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 20/32] usb: gadget: net2272: " Felipe Balbi
2013-01-24 15:45 ` [RFC/PATCH 21/32] usb: gadget: net2280: " Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 22/32] usb: gadget: pch_udc: " Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 23/32] usb: gadget: r8a66597-udc: " Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 24/32] usb: gadget: s3c-hsotg: " Felipe Balbi
2013-01-24 19:00   ` Tomasz Figa
2013-01-24 15:46 ` [RFC/PATCH 25/32] usb: gadget: s3c-hsudc: " Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 26/32] usb: gadget: s3c2410_udc: " Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 27/32] usb: renesas_usbhs: gadget: " Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 28/32] usb: gadget: pxa25x_udc: " Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 29/32] usb: gadget: pxa27x_udc: " Felipe Balbi
2013-01-28 20:18   ` Robert Jarzmik
2013-02-04 19:53     ` Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 30/32] usb: chipidea: register debugging syfs on our device Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 31/32] usb: chipidea: let udc-core manage gadget->dev Felipe Balbi
2013-01-24 15:46 ` [RFC/PATCH 32/32] usb: gadget: drop now unnecessary flag Felipe Balbi
2013-01-24 18:52   ` Tomasz Figa
2013-01-24 19:09     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359042370-4358-4-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ben-linux@fluff.org \
    --cc=dahlmann.thomas@arcor.de \
    --cc=eric.y.miao@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).