From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: David Airlie <airlied@linux.ie>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Alex Deucher <alexander.deucher@amd.com>,
Thadeu Cascardo <cascardo@linux.vnet.ibm.com>,
Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>,
Brian King <brking@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCHv2 1/3] pci: added pcie_get_speed_cap_mask function
Date: Wed, 27 Mar 2013 16:25:28 +0100 [thread overview]
Message-ID: <1364397928.11644.41.camel@pasglop> (raw)
In-Reply-To: <CAErSpo4rc=8mYgwuTO6693QCQJ9nsPsxmh7YAwxMygiVrPQR0A@mail.gmail.com>
On Tue, 2013-03-26 at 12:39 -0600, Bjorn Helgaas wrote:
> But we also know pdev is a PCIe device, and I think a PCIe device on a
> root bus must be a "Root Complex Integrated Endpoint" (PCIe spec sec
> 1.3.2.3). Such a device does not have a link at all, so there's no
> point in fiddling with its link speed.
This is where our IBM hypervisor makes things murky. It doesn't expose
the PCIe parents (basically somewhat makes PCIe look like PCI except we
still have the PCIe caps on the child devices, just no access to the
parent device).
It's garbage but can't be fixed (would break AIX :-)
However we might be able to populate the bus->max_bus_speed from some
architecture specific quirk and have radeon use that.
Cheers,
Ben.
next prev parent reply other threads:[~2013-03-27 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 5:24 [PATCHv2 0/3] PCI Speed Cap Fixes for ppc64 Lucas Kannebley Tavares
2013-03-20 5:24 ` [PATCHv2 1/3] pci: added pcie_get_speed_cap_mask function Lucas Kannebley Tavares
2013-03-26 18:39 ` Bjorn Helgaas
2013-03-27 15:25 ` Benjamin Herrenschmidt [this message]
2013-03-27 16:58 ` Bjorn Helgaas
2013-03-20 5:24 ` [PATCHv2 2/3] drm: removed drm_pcie_get_speed_cap_mask function Lucas Kannebley Tavares
2013-03-20 5:24 ` [PATCHv2 3/3] ppc64: implemented pcibios_get_speed_cap_mask Lucas Kannebley Tavares
2013-03-20 5:39 ` Benjamin Herrenschmidt
2013-03-20 15:34 ` [PATCHv2 0/3] PCI Speed Cap Fixes for ppc64 Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364397928.11644.41.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lucaskt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).