From: <Yuantian.Tang@freescale.com>
To: <grant.likely@secretlab.ca>
Cc: Tang Yuantian <Yuantian.Tang@freescale.com>,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
rob.herring@calxeda.com
Subject: [PATCH] of: remove the unnecessary of_node_put for of_parse_phandle_with_args()
Date: Tue, 9 Apr 2013 14:56:09 +0800 [thread overview]
Message-ID: <1365490569-32455-1-git-send-email-Yuantian.Tang@freescale.com> (raw)
From: Tang Yuantian <yuantian.tang@freescale.com>
As the function itself says it is caller's responsibility to call the
of_node_put(). So, remove it on success to keep the reference count
correct.
Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
drivers/of/base.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 321d3ef..e8b4c28 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1168,9 +1168,6 @@ static int __of_parse_phandle_with_args(const struct device_node *np,
out_args->args[i] = be32_to_cpup(list++);
}
- /* Found it! return success */
- if (node)
- of_node_put(node);
return 0;
}
--
1.8.0
next reply other threads:[~2013-04-09 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 6:56 Yuantian.Tang [this message]
2013-04-10 9:03 ` [PATCH] of: remove the unnecessary of_node_put for of_parse_phandle_with_args() Stephen Rothwell
2013-04-10 9:06 ` Tang Yuantian-B29983
2013-04-10 11:09 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365490569-32455-1-git-send-email-Yuantian.Tang@freescale.com \
--to=yuantian.tang@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).