From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe002.messaging.microsoft.com [216.32.180.12]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B91422C0091 for ; Wed, 10 Apr 2013 13:20:17 +1000 (EST) Date: Tue, 9 Apr 2013 22:20:08 -0500 From: Scott Wood Subject: Re: [PATCH V4] powerpc/MPIC: Add get_version API both for internal and external use To: Jia Hongtao-B38951 References: <1365386514-14647-1-git-send-email-hongtao.jia@freescale.com> <1365561148.29365.0@snotra> <412C8208B4A0464FA894C5F0C278CD5D01C3557B@039-SN1MPN1-003.039d.mgd.msft.net> <1365563255.29365.1@snotra> <412C8208B4A0464FA894C5F0C278CD5D01C35599@039-SN1MPN1-003.039d.mgd.msft.net> <1365563520.29365.2@snotra> <412C8208B4A0464FA894C5F0C278CD5D01C355B5@039-SN1MPN1-003.039d.mgd.msft.net> In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01C355B5@039-SN1MPN1-003.039d.mgd.msft.net> (from B38951@freescale.com on Tue Apr 9 22:14:06 2013) Message-ID: <1365564008.29365.3@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Cc: Wood Scott-B07421 , "linuxppc-dev@lists.ozlabs.org" , Li Yang-R58472 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/09/2013 10:14:06 PM, Jia Hongtao-B38951 wrote: >=20 >=20 > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, April 10, 2013 11:12 AM > > To: Jia Hongtao-B38951 > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > galak@kernel.crashing.org; Li Yang-R58472 > > Subject: Re: [PATCH V4] powerpc/MPIC: Add get_version API both for > > internal and external use > > > > On 04/09/2013 10:10:37 PM, Jia Hongtao-B38951 wrote: > > > > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, April 10, 2013 11:08 AM > > > > To: Jia Hongtao-B38951 > > > > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > > > > galak@kernel.crashing.org; Li Yang-R58472 > > > > Subject: Re: [PATCH V4] powerpc/MPIC: Add get_version API both =20 > for > > > > internal and external use > > > > > > > > On 04/09/2013 10:04:44 PM, Jia Hongtao-B38951 wrote: > > > > > Since all the functions including mpic_alloc() and =20 > mpic_init() do > > > the > > > > > check for MPIC_FSL before using fsl_mpic_get_version() I'd =20 > like > > > to add > > > > > check just for fsl_mpic_primary_get_version(). > > > > > > > > > > It will be like this: > > > > > u32 fsl_mpic_primary_get_version(void) > > > > > { > > > > > struct mpic *mpic =3D mpic_primary; > > > > > > > > > > if (mpic && (mpic->flags & MPIC_FSL)) > > > > > return fsl_mpic_get_version(mpic); > > > > > > > > > > return 0; > > > > > } > > > > > > > > > > Could we reach an agreement here? > > > > > > > > Is there any particular reason? It would be more robust and =20 > more > > > > consistent if the check were done in fsl_mpic_get_version(). > > > > > > > > -Scott > > > > > > I found out that all the functions using fsl_mpic_get_version() =20 > have > > > already done the check. Adding the check in fsl_mpic_get_version() > > > will cause duplicate check there. This is my consideration. > > > > Does that duplicate check cause any harm? > > > > -Scott >=20 > No harm at all just not necessary. Not *necessary*, but makes it more robust and more consistent. > I wonder if I could add check in fsl_mpic_get_version() and remove =20 > all the > check from functions in which using fsl_mpic_get_version()? One of the two places that calls it is the place that maps thiscpuregs =20 in the first place, so no. :-) The check in mpic_init() for the number of timers could perhaps have =20 the check removed if we're comfortable equating a version of zero with =20 a non-FSL MPIC. This really isn't something that's worth worrying =20 about, though. -Scott=