linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Li Zhong <zhong@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: paulus@samba.org, Li Zhong <zhong@linux.vnet.ibm.com>
Subject: [RFC PATCH v2 0/4] try secondary hash before BUG in kernel_map_linear_page()
Date: Fri, 12 Apr 2013 10:16:56 +0800	[thread overview]
Message-ID: <1365733021-28912-1-git-send-email-zhong@linux.vnet.ibm.com> (raw)

Hi Michael, 

Here is the updated version,  could you please help to review it again? 

As you suggested, this version didn't copy the code, but splitted
the logic into a helper function, so both kernel_map_linear_page() and
__hash_page_huge() can use. 

Also patch #1 moves some unnecessary code out of the repeating loop, so the 
splitting is easier. Patch #3 removes the HPTE_V_BOLTED flag in 
kernel_map_linear_page(), it seems not needed based on my understanding. 

Changes are split into smaller ones, so each one did only one thing. 

Thanks, Zhong

Li Zhong (4):
  powerpc: Move the setting of rflags out of loop in __hash_page_huge
  powerpc: Split the code trying to insert hpte repeatedly as an helper
    function
  powerpc: Don't bolt the hpte in kernel_map_linear_page()
  powerpc: Try to insert the hptes repeatedly in
    kernel_map_linear_page()

 arch/powerpc/mm/hash_utils_64.c      |   45 +++++++++++++++++++++++++++++++---
 arch/powerpc/mm/hugetlbpage-hash64.c |   31 +++++------------------
 2 files changed, 47 insertions(+), 29 deletions(-)

-- 
1.7.9.5

             reply	other threads:[~2013-04-12  2:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12  2:16 Li Zhong [this message]
2013-04-12  2:16 ` [RFC PATCH v2 1/4] powerpc: Move the setting of rflags out of loop in __hash_page_huge Li Zhong
2013-04-15  6:32   ` Michael Ellerman
2013-04-15  8:17     ` Li Zhong
2013-04-12  2:16 ` [RFC PATCH v2 2/4] powerpc: Split the code trying to insert hpte repeatedly as an helper function Li Zhong
2013-04-12  2:16 ` [RFC PATCH v2 3/4] powerpc: Don't bolt the hpte in kernel_map_linear_page() Li Zhong
2013-04-15  3:50   ` Paul Mackerras
2013-04-15  6:56     ` Benjamin Herrenschmidt
2013-04-15  8:15       ` Li Zhong
2013-04-15 11:27         ` Benjamin Herrenschmidt
2013-04-16  2:51           ` Li Zhong
2013-04-12  2:17 ` [RFC PATCH v2 4/4] powerpc: Try to insert the hptes repeatedly " Li Zhong
2013-04-15  6:36   ` Michael Ellerman
2013-04-15  8:21     ` Li Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365733021-28912-1-git-send-email-zhong@linux.vnet.ibm.com \
    --to=zhong@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).