* [PATCH] usb: remove redundant tdi_reset
@ 2013-04-17 10:03 Shengzhou Liu
2013-04-17 15:03 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Shengzhou Liu @ 2013-04-17 10:03 UTC (permalink / raw)
To: linuxppc-dev, stable, linux-usb; +Cc: Shengzhou Liu
We remove the redundant tdi_reset in ehci_setup since there
is already it in ehci_reset.
It was observed that the duplicated tdi_reset was causing
the PHY_CLK_VALID bit unstable.
Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
---
drivers/usb/host/ehci-hcd.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 416a6dc..83b5a17 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -670,9 +670,6 @@ int ehci_setup(struct usb_hcd *hcd)
if (retval)
return retval;
- if (ehci_is_TDI(ehci))
- tdi_reset(ehci);
-
ehci_reset(ehci);
return 0;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: remove redundant tdi_reset
2013-04-17 10:03 [PATCH] usb: remove redundant tdi_reset Shengzhou Liu
@ 2013-04-17 15:03 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2013-04-17 15:03 UTC (permalink / raw)
To: Shengzhou Liu; +Cc: linux-usb, linuxppc-dev, stable
On Wed, 17 Apr 2013, Shengzhou Liu wrote:
> We remove the redundant tdi_reset in ehci_setup since there
> is already it in ehci_reset.
> It was observed that the duplicated tdi_reset was causing
> the PHY_CLK_VALID bit unstable.
>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
> drivers/usb/host/ehci-hcd.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 416a6dc..83b5a17 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -670,9 +670,6 @@ int ehci_setup(struct usb_hcd *hcd)
> if (retval)
> return retval;
>
> - if (ehci_is_TDI(ehci))
> - tdi_reset(ehci);
> -
> ehci_reset(ehci);
>
> return 0;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
This should be applied to stable kernels going back to 3.6.
In case you are wondering why that redudant call was added, I did it
because some of the PCI drivers (Intel and TDI) already had calls to
tdi_reset. The commit removed those calls, so the new one was added
in.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-17 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-17 10:03 [PATCH] usb: remove redundant tdi_reset Shengzhou Liu
2013-04-17 15:03 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).