From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/5] powerpc/powernv: TCE invalidation for PHB3
Date: Wed, 24 Apr 2013 01:25:08 +1000 [thread overview]
Message-ID: <1366730708.12131.7.camel@pasglop> (raw)
In-Reply-To: <1366715034-24594-6-git-send-email-shangw@linux.vnet.ibm.com>
On Tue, 2013-04-23 at 19:03 +0800, Gavin Shan wrote:
> * of flags if that becomes the case
> */
> if (tbl->it_type & TCE_PCI_SWINV_CREATE)
> - pnv_tce_invalidate(tbl, tces, tcep - 1);
> + phb->dma_tce_invalidate(tbl, tces, tcep - 1);
>
> return 0;
> }
TCE invalidate is very performance sensitive, we might be better off
doing the if (ioda_type == PNV_PHB_IODA1) ... else ... here (which
the CPU can generally predict) rather than a function pointer call
which can be more tricky.
Cheers,
Ben.
next prev parent reply other threads:[~2013-04-23 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 11:03 [PATCH v2 0/5] powerpc/powernv: PHB3 Support Gavin Shan
2013-04-23 11:03 ` [PATCH 1/5] powerpc/powernv: Supports PHB3 Gavin Shan
2013-04-23 15:19 ` Benjamin Herrenschmidt
2013-04-24 1:29 ` Gavin Shan
2013-04-23 11:03 ` [PATCH 2/5] powerpc/powernv: Retrieve IODA2 tables explicitly Gavin Shan
2013-04-23 11:03 ` [PATCH 3/5] powerpc/powernv: Add option CONFIG_POWERNV_MSI Gavin Shan
2013-04-23 11:03 ` [PATCH 4/5] powerpc/powernv: Patch MSI EOI handler on P8 Gavin Shan
2013-04-23 15:21 ` Benjamin Herrenschmidt
2013-04-24 1:31 ` Gavin Shan
2013-04-23 11:03 ` [PATCH 5/5] powerpc/powernv: TCE invalidation for PHB3 Gavin Shan
2013-04-23 15:25 ` Benjamin Herrenschmidt [this message]
2013-04-24 1:32 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366730708.12131.7.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).