From: Michael Ellerman <michael@ellerman.id.au>
To: <linuxppc-dev@ozlabs.org>
Cc: Arnd Bergmann <arnd.bergmann@de.ibm.com>,
viro@zeniv.linux.org.uk, dchinner@redhat.com,
Christoph Hellwig <hch@lst.de>, Jeremy Kerr <jk@ozlabs.org>
Subject: [PATCH] powerpc/spufs: Initialise inode->i_ino in spufs_new_inode()
Date: Wed, 24 Apr 2013 11:13:14 +1000 [thread overview]
Message-ID: <1366765994-13486-1-git-send-email-michael@ellerman.id.au> (raw)
In commit 85fe402 (fs: do not assign default i_ino in new_inode), the
initialisation of i_ino was removed from new_inode() and pushed down
into the callers. However spufs_new_inode() was not updated.
This exhibits as no files appearing in /spu, because all our dirents
have a zero inode, which readdir() seems to dislike.
Cc: stable@vger.kernel.org
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
arch/powerpc/platforms/cell/spufs/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index 3f3bb4c..35f77a4 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -99,6 +99,7 @@ spufs_new_inode(struct super_block *sb, umode_t mode)
if (!inode)
goto out;
+ inode->i_ino = get_next_ino();
inode->i_mode = mode;
inode->i_uid = current_fsuid();
inode->i_gid = current_fsgid();
--
1.7.10.4
next reply other threads:[~2013-04-24 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 1:13 Michael Ellerman [this message]
2013-04-24 1:16 ` [PATCH] powerpc/spufs: Initialise inode->i_ino in spufs_new_inode() Benjamin Herrenschmidt
2013-04-24 1:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366765994-13486-1-git-send-email-michael@ellerman.id.au \
--to=michael@ellerman.id.au \
--cc=arnd.bergmann@de.ibm.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).