* [PATCH] powerpc/spufs: Initialise inode->i_ino in spufs_new_inode()
@ 2013-04-24 1:13 Michael Ellerman
2013-04-24 1:16 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2013-04-24 1:13 UTC (permalink / raw)
To: linuxppc-dev
Cc: Arnd Bergmann, viro, dchinner, Christoph Hellwig, Jeremy Kerr
In commit 85fe402 (fs: do not assign default i_ino in new_inode), the
initialisation of i_ino was removed from new_inode() and pushed down
into the callers. However spufs_new_inode() was not updated.
This exhibits as no files appearing in /spu, because all our dirents
have a zero inode, which readdir() seems to dislike.
Cc: stable@vger.kernel.org
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
arch/powerpc/platforms/cell/spufs/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index 3f3bb4c..35f77a4 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -99,6 +99,7 @@ spufs_new_inode(struct super_block *sb, umode_t mode)
if (!inode)
goto out;
+ inode->i_ino = get_next_ino();
inode->i_mode = mode;
inode->i_uid = current_fsuid();
inode->i_gid = current_fsgid();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/spufs: Initialise inode->i_ino in spufs_new_inode()
2013-04-24 1:13 [PATCH] powerpc/spufs: Initialise inode->i_ino in spufs_new_inode() Michael Ellerman
@ 2013-04-24 1:16 ` Benjamin Herrenschmidt
2013-04-24 1:50 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2013-04-24 1:16 UTC (permalink / raw)
To: Michael Ellerman
Cc: Arnd Bergmann, linuxppc-dev, viro, dchinner, Christoph Hellwig,
Jeremy Kerr
On Wed, 2013-04-24 at 11:13 +1000, Michael Ellerman wrote:
> In commit 85fe402 (fs: do not assign default i_ino in new_inode), the
> initialisation of i_ino was removed from new_inode() and pushed down
> into the callers. However spufs_new_inode() was not updated.
>
> This exhibits as no files appearing in /spu, because all our dirents
> have a zero inode, which readdir() seems to dislike.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Christoph/Al, can I have an Ack for this before I shoot it to Linus ?
Thanks !
Cheers,
Ben.
---
> arch/powerpc/platforms/cell/spufs/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/cell/spufs/inode.c
b/arch/powerpc/platforms/cell/spufs/inode.c
> index 3f3bb4c..35f77a4 100644
> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -99,6 +99,7 @@ spufs_new_inode(struct super_block *sb, umode_t
mode)
> if (!inode)
> goto out;
>
> + inode->i_ino = get_next_ino();
> inode->i_mode = mode;
> inode->i_uid = current_fsuid();
> inode->i_gid = current_fsgid();
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-24 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-24 1:13 [PATCH] powerpc/spufs: Initialise inode->i_ino in spufs_new_inode() Michael Ellerman
2013-04-24 1:16 ` Benjamin Herrenschmidt
2013-04-24 1:50 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).