From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jia Hongtao-B38951 <B38951@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc: Move opcode definitions from kvm/emulate.c to asm/ppc-opcode.h
Date: Wed, 24 Apr 2013 14:19:21 +1000 [thread overview]
Message-ID: <1366777161.2869.0.camel@pasglop> (raw)
In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01C4A4B0@039-SN1MPN1-002.039d.mgd.msft.net>
On Tue, 2013-04-23 at 06:36 +0000, Jia Hongtao-B38951 wrote:
> These definitions are firstly used by KVM defined like OP_31_XOP_TRAP.
> Two ways to extract these definitions for public use:
>
> 1. Like this patch did. For keeping the KVM code that using these
> definitions unchanged we do not update them to match.
>
> 2. Move these definitions to another .h file like my last patch did:
> http://patchwork.ozlabs.org/patch/235646/
> You can see the comments there.
There's a better way ... but it's more work.
All opcodes are based on a primary opcode and a potential secondary
opcode. You could/should rework ppc-opcodes.h to in fact define them
all that way as well, which would "reconcile" the KVM way and the
existing stuff.
Cheers,
Ben.
> Thanks.
> -Hongtao
>
>
>
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2013-04-24 4:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 2:39 [PATCH 1/2] powerpc: Move opcode definitions from kvm/emulate.c to asm/ppc-opcode.h Jia Hongtao
2013-04-23 2:39 ` [PATCH 2/2 V7] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx Jia Hongtao
2013-04-25 15:31 ` Segher Boessenkool
2013-04-25 16:58 ` Scott Wood
2013-04-25 17:32 ` Segher Boessenkool
2013-04-27 2:26 ` Jia Hongtao-B38951
2013-04-27 13:31 ` Segher Boessenkool
2013-04-28 2:20 ` Jia Hongtao-B38951
2013-04-29 20:29 ` Scott Wood
2013-05-02 7:00 ` Jia Hongtao-B38951
2013-04-23 5:29 ` [PATCH 1/2] powerpc: Move opcode definitions from kvm/emulate.c to asm/ppc-opcode.h Michael Ellerman
2013-04-23 6:36 ` Jia Hongtao-B38951
2013-04-24 4:19 ` Benjamin Herrenschmidt [this message]
2013-04-26 2:40 ` Jia Hongtao-B38951
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366777161.2869.0.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B07421@freescale.com \
--cc=B38951@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).